Bash script - too many arguments

Question

Why doesn't the following work? All I'm trying to do is execute a adb command and, if the response contains a certain string, then doing something about it.

I keep getting an error [; too many arguments

VARIABLE=$(adb devices);
if [ "$VARIABLE" == *list of attached* ]; then
  echo "adb command worked";
fi

Any ideas?

On another note: the command adb devices returns words List of devices attached, not list of attached. So your if statement may always return false. — anishsane
– anishsane, Commented Jan 27, 2014 at 6:10

mklement0 · Accepted Answer · 2014-01-27 04:15:10Z

6

Try quoting the arguments inside [[ and ]]:

VARIABLE="$(adb devices)"
if [[ "$VARIABLE" == *"list of attached"* ]]; then
  echo "adb command worked";
fi

== needs single argument on either side. When you use [ "$VARIABLE" == *list of attached* ] then *list is the first argument after == and rest are considered extra arguments.

edited Jan 27, 2014 at 4:15

mklement0

452k68 gold badges728 silver badges988 bronze badges

answered Jan 27, 2014 at 2:39

anubhava

790k67 gold badges603 silver badges671 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

that other guy Over a year ago

adb devices probably also returns a good exit code, in which case if adb devices > /dev/null 2>&1; then .. would be the correct way (but not the questioner's way) of doing this.

John B · Accepted Answer · 2014-01-29 17:21:21Z

1

You could alternatively try using BASH's binary operator =~ to do regex matching:

VARIABLE="$(adb devices)"
if [[ $VARIABLE =~ list\ of\ attached ]]; then
    echo "adb command worked"
fi

edited Jan 29, 2014 at 17:21

answered Jan 27, 2014 at 3:44

John B

3,6661 gold badge19 silver badges22 bronze badges

2 Comments

mklement0 Over a year ago

Terminology hint: Wildcard characters are associated with globbing patterns - which is the feature the OP uses. The =~ operator is for regular expression-matching.

John B Over a year ago

@mklement0 You are correct. Updated post to avoid any confusion.

Collectives™ on Stack Overflow

Bash script - too many arguments

2 Answers 2

1 Comment

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related