Controller action not running in rspec test

Question

I'm trying to test the index action of a controller that I have. I want it to return instances of something called Moments, which belong to a user. I am using FactoryGirl and Rspec. I verify the user has moments, as when I call @user.moments, it returns them. However when I use get :index, it returns a 200 with an empty response.body.

Here is my Rspec:

require 'spec_helper'

describe Api::V1::MomentsController do

    before do
        @moment = FactoryGirl.create(:moment)
    end
    it 'should return moments' do
        expect(controller).to receive(:index)
        @user = @moment.user
        request.env['Authorization'] = "Token token=#{@user.authentication_token}"
        get :index
        expect(response.status).to eq(200)
        puts response.body
    end
    after do
        @moment = nil
        @user = nil
    end 
end

Here is my Factory:

FactoryGirl.define do
    def time_rand from = 0.0, to = Time.now 
      Time.at(from + rand * (to.to_f - from.to_f))
    end
    sequence :email do |n|
      "email#{n}@ploonky.com"
    end
    sequence :fullname do |n|
      "Waiter Number#{n}"
    end
    sequence :handle do |n|
      "Person#{n}"
    end

    factory :user, :aliases => [:owner] do
      fullname 
      birthdate "1978-12-12"
      email 
      password "password1"
      password_confirmation "password1"
      handle
      tags {
        Array(10).sample.times.map do
          FactoryGirl.create(:tag)
        end
      }
   end
   sequence :datetime do
     "#{time_rand}"
   end
   factory :moment do
     datetime 
     text "can't wait to get through this busy day"
     association :location, :factory => :location 
     user_id { location.user_id }
     is_public true
     is_deleted false
   end

  factory :location do
    label "home"
    street "248 Mckibbin st"
    city "brooklyn"
    state "NY"
    zip "11206"
    latitude 40.7063048
    longitude -73.9396323 
    association :user, :factory => :user
    country "USA"
    is_deleted false
  end

  factory :tag do 
    value "busy as hell"
    is_deleted false 
  end
end

And finally, the controller action:

class Api::V1::MomentsController < ApplicationController
  before_filter :restrict_access, :except => :public
  respond_to :json
  def index
    updateDate=params['updated_at'] ? DateTime.iso8601(params['updated_at']) : nil
    include_deleted = params['include_deleted'] ? params['include_deleted'].to_i : nil

    friends_ids=Friendship.get_friends(api_user,Friendship::APPROVED)
    friends_ids=friends_ids.map do |friend_ids|
      if friend_ids
        friend_ids[:id]
      end
    end
    user_ids=friends_ids.append(api_user.id) 

    moments=Moment.user_moments(user_ids, include_deleted == 1)

    #filter out moments older than updateDate
    if updateDate
      moments=moments.where('updated_at>?',updateDate)
    end
    moments=buildFullMoments(moments, api_user)
    render :json => moments
  end
end

I was having a the same issue, but the cause was my test user wasn't actually authenticating and it just wasn't apparent since no actual error is being raised. So I guess it's a good idea to first look at whatever methods are handling authentication before going down a potential rabbit-hole. — Ten Bitcomb
– Ten Bitcomb, Commented Apr 9, 2017 at 4:06

Derek Prior · Accepted Answer · 2014-01-28 22:48:36Z

1

expect(controller).to receive(:index)

You've just stubbed your controller action. None of the code in your controller action is now running. Remove this line.

answered Jan 28, 2014 at 22:48

Derek Prior

3,5091 gold badge27 silver badges30 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

DiegoSalazar · Accepted Answer · 2014-01-28 22:52:34Z

1

What Derek said and also you need to pass in the format of the request:

get :index, format: :json

since your controller will only respond_to :json

answered Jan 28, 2014 at 22:52

DiegoSalazar

13.5k2 gold badges42 silver badges58 bronze badges

Collectives™ on Stack Overflow

Controller action not running in rspec test

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related