MVC ASP.NET querystring incorrect

Question

I have a problem with my querystring, i call an action in my controller with javascript like this

if ((event >= 65) && (event <= 90) || (event >= 48) && (event <= 57)) {
    var focussed = document.activeElement.id;
    window.setTimeout(function () {
        alert(in2.value);
        location.href = "/CarSaldi/ListaArt?in1=" + in1.value + "&in2=" + in2.value + "&focus=" + focussed;
    }, 1000);
}

in2 is a input text and might have a "+" inside it (for example "milk+chocolate"), when i call the action in my controller

public ActionResult ListaArt(string in1, string in2, string cod, string focus)
{
    [...]
}

the string in2 shows my "milk chocolate", i expected milk+chocolate...i need to have also the "+" inside.

have a look here: stackoverflow.com/a/6855723/148998

shenku
– shenku

2014-02-25 11:18:09 +00:00
Commented Feb 25, 2014 at 11:18 — shenku
– shenku, Commented Feb 25, 2014 at 11:18
possible duplicate of Plus sign in query string

shenku
– shenku

2014-02-25 11:18:19 +00:00
Commented Feb 25, 2014 at 11:18 — shenku
– shenku, Commented Feb 25, 2014 at 11:18

शेखर · Accepted Answer · 2014-02-25 11:20:00Z

4

You should use java script function encodeURIComponent to encode url.

location.href = "/CarSaldi/ListaArt?in1=" + encodeURIComponent(in1.value) 
 + "&in2=" + encodeURIComponent(in2.value) + "&focus=" + encodeURIComponent(focussed);

You need to change you code as follows

if ((event >= 65) && (event <= 90) || (event >= 48) && (event <= 57)) {
var focussed = document.activeElement.id;
window.setTimeout(function () {
    alert(in2.value);
    location.href = "/CarSaldi/ListaArt?in1=" + encodeURIComponent(in1.value) 
 + "&in2=" + encodeURIComponent(in2.value) + "&focus=" + encodeURIComponent(focussed);
  }, 1000);
}

answered Feb 25, 2014 at 11:20

शेखर

17.6k14 gold badges64 silver badges123 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Shiva Saurabh · Accepted Answer · 2014-02-25 11:29:42Z

2

Use encodeURIComponent(yourParameter).

In this case special characters are not lost

edited Feb 25, 2014 at 11:29

answered Feb 25, 2014 at 11:20

Shiva Saurabh

1,2892 gold badges26 silver badges47 bronze badges

Comments

Andrei · Accepted Answer · 2014-02-25 11:18:53Z

1

Plus sign should be URL encoded in your case:

 +   =  %2B

So instead of using '+' in the URL use '%2B'

See the full table of URL encoded characters: http://www.degraeve.com/reference/urlencoding.php

answered Feb 25, 2014 at 11:18

Andrei

44.9k39 gold badges163 silver badges228 bronze badges

3 Comments

theLaw Over a year ago

so i can do replace in javascript with %2b

Andrei Over a year ago

@theLaw Yes, for example

Andrei Over a year ago

@theLaw better use built-in encodeURIComponent(string) function

Ranjith Kumar Nagiri · Accepted Answer · 2014-03-03 13:07:42Z

1

Encode your string using the javascript function encodeURIComponent:

you can use:

 encodeURIComponent(in1.value)

edited Mar 3, 2014 at 13:07

Ranjith Kumar Nagiri

8613 gold badges18 silver badges42 bronze badges

answered Feb 25, 2014 at 11:20

rajeemcariazo

2,5445 gold badges39 silver badges63 bronze badges

Comments

eiximenis · Accepted Answer · 2014-02-25 11:51:03Z

Never, never, never construct your query string in asp.net mvc using javascript and string conatenation. Always let this to Url.Action. The main reason is that what is left on querystring and what is inside the pathinfo depends on how your routes are defined. If you want to give yourself the chance to change your routes easily in the future, use always Url.Action:

var uri = "@Url.Action("ListaArt", CarSaldi", new {in1="xxx", in2="yyy", focus="zzz"})".replace("&amp;","&");
// Replace the "placeholders" values to the real ones
uri = uri.replace("xxx", in1.value);
uri = uri.replace("yyy", in2.value);
uri = uri.replace("yyy", focussed);
location.href = uri;

And regarding the plus sign you need to use encodeURIComponent method in Javascript:

uri = uri.replace("yyy", encodeURIComponent(in2.value));

Hope this helps!

PS: The replace("&","&") is needed because Url.Action generates URLs using & instead of & for separating the tokens of the querystring. This is good for HTML (you can put this in the href of a A tag) but not for the location.href property.

Collectives™ on Stack Overflow

MVC ASP.NET querystring incorrect

5 Answers 5

Comments

Comments

3 Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

3 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related