Java - Static Programming Style

Question

When I first started learning java GUI (swing) programming the way I was shown was more of an MVC model which involved using interfaces to call things and pass variables across classes.

I recently started programming in a more static way, having a Jframe call its static Jpanel's and using static methods to change components. Bascially i program everything statically so I can call them from the different classes with ease.

Heres an example:

My main JFrame class called "Home", I initialise the Toolbar class statically:

private static Toolbar toolbar = new Toolbar();

Now whenever I want to do something e.g. change the colour I just call from another class:

Home.toolbar.setForeground(Color.green);

Is this an ok way of programming? So far i've not run into any troubles but I was caught out by the fact that the people I learnt from didn't do this when it seems so much easier to do.

Are there any big down sides to this way of programming? What are the alternatives?

Maroun · Accepted Answer · 2014-03-20 15:11:53Z

4

Basically, you should ask yourself:

"Should toolbar be associated with each object I create? Or should it be one for all objects, and once I change it, it changes for all objects?"

If you answer yourself "Yes", then it's OK, otherwise it shouldn't be static.

Of course there are many things to consider beside that.. For example, static resources are not thread-safe.

answered Mar 20, 2014 at 15:11

Maroun

96.3k30 gold badges195 silver badges249 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Crizly Over a year ago

Answer is probably yes - when I make GUI components they are usually the same across the board. I usually only need one of them. I'll have to look into the thread-safe thing too, never really considered it.

Luiggi Mendoza Over a year ago

@Crizly MarounMaroun means that you need to extrapolate this question for every field you will define in order to know if it would be static or non-static, the toolbar was just an example.

Isaiah van der Elst · Accepted Answer · 2014-03-20 15:17:56Z

3

If it works, then great... It's correct.

However, I make it my goal to write code that's both maintainable and testable. The problem with static instances is that it creates strong coupling throughout the entire project. Moreover, trying to isolate a class is impossible because the static dependency cannot be mocked or injected.

Typically, GUI code cannot be unit tested. MVC, however, ensures that the testable code is separated from the GUI code.

answered Mar 20, 2014 at 15:17

Isaiah van der Elst

1,4559 silver badges15 bronze badges

2 Comments

Crizly Over a year ago

I'm pretty new to java learning it at university, which bits of the code would need to be unit tested?

Isaiah van der Elst Over a year ago

The model and the controller need to be tested. The logic in the view should be limited to managing the UI. The idea is that we separate out any business and procedural logic from the UI and test that.

Collectives™ on Stack Overflow

Java - Static Programming Style

2 Answers 2

2 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related