If else using for setting class

Question

I want to set every first and second tr with a different class. With my code I only get "odd" on every tr. Does anyone knew what is wrong?

 $rowCount = 0;
 if ($rowCount++ % 2 == 1 ) :
     echo "<tr class='even'>";
 else:
     echo "<tr class='odd'>";
 endif;

Well from just that code, it looks like you are setting $rowCount = 0 every time. Can you provide a bit more information. Also, why wouldn't you just use a conditional operator? e.g. echo '<tr class="' . (($rowCount++ % 2) ? 'even' : 'odd') . '>' — p.s.w.g
– p.s.w.g, Commented Mar 27, 2014 at 15:15
I find out what i have done wrong. I put the $rowCount = 0; in the while. — user1551496
– user1551496, Commented Mar 27, 2014 at 15:54

Luis Masuelli · Accepted Answer · 2014-03-27 15:16:17Z

2

try this one (keep the $rowCount setting outside the loop):

for($row = 0; $row < $rowTotal; $row++)
{
   echo "<tr class='".($row % 2 ? "even" : "odd")."'>";
}

answered Mar 27, 2014 at 15:16

Luis Masuelli

12.4k11 gold badges53 silver badges89 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

TheMohanAhuja · Accepted Answer · 2014-03-28 04:27:23Z

1

Your logic implementation is going in wrong direction

$rowCount = 0;//This was always initializing your count to 0

Resulting always odd class added

Change it to this:

for ($rowCount = 0;$rowCount<$total; $rowCount++) {
    if ($rowCount % 2 == 1 ) :
        echo "<tr class='even'>";
    else:
        echo "<tr class='odd'>";
    endif;
}

OR you can simply use ternary operator as

for ($rowCount=0; $rowCount<$total; $rowCount++) {
    echo "<tr class='".($rowCount % 2 == 0 )?'odd':'even'."'>";
}

edited Mar 28, 2014 at 4:27

answered Mar 27, 2014 at 15:26

TheMohanAhuja

1,8752 gold badges19 silver badges30 bronze badges

1 Comment

Luis Masuelli Over a year ago

the for loop has an error in your code. actually the error is in the loop body: remove the additional ++ (in the ternary-op expression), since having it twice will increment twice the number per iteration.

Collectives™ on Stack Overflow

If else using for setting class

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related