Unable to save model instance with django

Question

I am attempting to save simple data based on a button submission. But i keep getting following error:

TypeError at /exercise/1/
save() got an unexpected keyword argument 'commit'

models.py:

class StrategyHistory(models.Model):
    user = models.ForeignKey(User)
    strategy = models.ForeignKey(Strategies)

    created = models.DateTimeField(editable=False)
    modified = models.DateTimeField()

    def save(self, *args, **kwargs):
        ''' On save, update timestamps '''
        if not self.id:
            self.created = datetime.datetime.today()
        self.modified = datetime.datetime.today()
        return super(StrategyHistory, self).save(*args, **kwargs)

    def __unicode__(self):
        return self.strategy.name

views.py:

def exercise_view(request, pk):
    template_name = 'mobileApp/page/exercise.html'
    if not request.user.is_authenticated():
        return HttpResponseRedirect(reverse('mobile_user_login'))

    strategy = Strategies.objects.get(pk=pk)

    context = {
        'strategy':strategy,
    }

    if request.method == 'POST':
        strategyhistory = StrategyHistory()
        entry = strategyhistory.save(commit=False)
        entry.user = self.request.user
        entry.strategy = Strategies.objects.get(id=pk)
        entry.save()
        if pk < 5:
            return HttpResponseRedirect(reverse('mobile_exercise', kwargs={'pk':pk+1}))
        else:
            return HttpResponseRedirect(reverse('mobile_comeback_later'))

    return render_to_response(template_name,
    context,
    context_instance = RC( request, {} ))

html-file:

        <form action="" method="post">{% csrf_token  %}
            <a href="#" data-role="button" data-inline="true" data-rel="back" data-transition="flow" data-icon="refresh" data-theme="c">Prøv igen</a>
            <button type="submit" value="submit" data-inline="true" data-transition="flow" data-icon="check" data-theme="b">Fortsæt</button>
        </form>

I am running Django 1.6.2

for the creation and update time, I have this in my project: creation_time = models.DateTimeField(auto_now_add = True, auto_now = False) update_time = models.DateTimeField(auto_now_add = False, auto_now = True) — Mihai Zamfir
– Mihai Zamfir, Commented Apr 2, 2014 at 13:41
You don't have to specify both auto_now only the one you want in action. — Bogdan Iulian Bursuc
– Bogdan Iulian Bursuc, Commented Apr 2, 2014 at 14:23

Bogdan Iulian Bursuc · Accepted Answer · 2014-04-02 13:27:31Z

Your view use StrategyHistory model incorrect. That is the use of forms. This is correct.

def exercise_view(request, pk):
    template_name = 'mobileApp/page/exercise.html'
    if not request.user.is_authenticated():
        return HttpResponseRedirect(reverse('mobile_user_login'))

    strategy = Strategies.objects.get(pk=pk)

    context = {
        'strategy':strategy,
    }

    if request.method == 'POST':
        strategyhistory = StrategyHistory.objects.create(
            user=request.user,
            strategy=strategy)
        if pk < 5:
            return HttpResponseRedirect(reverse('mobile_exercise', kwargs={'pk': pk + 1}))
        else:
            return HttpResponseRedirect(reverse('mobile_comeback_later'))

    return render_to_response(template_name,
                              context,
                              context_instance = RC( request, {} ))

Also you cannot use self.request in that view. There is no self declared.

shellbye · Accepted Answer · 2014-04-02 13:39:46Z

0

May be this is what you want:

class StrategyHistory(models.Model):
    user = models.ForeignKey(User)
    strategy = models.ForeignKey(Strategies)

    created = models.DateTimeField(auto_now_add=True)
    modified = models.DateTimeField(auto_now=True)


    def __unicode__(self):
        return self.strategy.name

answered Apr 2, 2014 at 13:39

shellbye

4,8884 gold badges34 silver badges44 bronze badges

Collectives™ on Stack Overflow

Unable to save model instance with django

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related