From a OO perspective, are enums supposed to be within a separate class? I have seen a few examples of this. I am wondering if this is the correct way to do it? (just trying to learn the 'proper' way of doing things.
-
If you use your enum only in one class, it can be an "inner enum". Most often you'll end making it public but refactoring is cheap and easy.Denys Séguret– Denys Séguret2014-05-06 11:50:32 +00:00Commented May 6, 2014 at 11:50
Add a comment
|
4 Answers
There is no universally "proper" way of defining enums - it goes the same way as other entities that can be nested or could exist on their own, such as classes and interfaces.
- When your
enumis intended for use only with a particular class, for example, to enumerate options of one of its methods, definingenuminside the class is reasonable - When your
enumis intended to be shared among multiple classes, define it at the top level.
answered May 6, 2014 at 11:52
Sergey Kalinichenko
729k85 gold badges1.2k silver badges1.6k bronze badges
Comments
If the enum constants are used by multiple classes, then it can be in separate class. Otherwise, if it's used only within a class, it can be private inner enum class.
answered May 6, 2014 at 11:51
Abimaran Kugathasan
32.7k11 gold badges81 silver badges109 bronze badges
Comments
If only one class is using those enums, you better have them in that class and mark them private. But if their scope is more than one class, you obviously need to have those enums at a place where they could be accessed by all the classes that need them.
Comments
As suggested in above answer it all depend on requirements. I think it is worthwhile to make it public/separate for reusability and decoupling point of view.
