Creating an array of structs defined in another header file

Question

I have the following file structure

service.h
config.h
config.c

In the service.h file a struct serviceStruct is declared with one member a unsigned int.

I declare an array of serviceStructs in the file config.h and in the config.c file, I initialize the members.

Now I get the error array type has incomplete element type

How can i solve this error?

[update from comment:]

service.h:

typedef uint32_t board_spi_select_id_t;

struct spi_device
{ //! Board specific select id 
  board_spi_select_id_t id;
};

config.h:

#include "service.h" 

#define SPI_SLAVE_COUNT 4 
#define SPI_SS_ADF4350_C1 0 
#define SPI_SS_ADF4350_C2 99 
#define SPI_SS_AD9854_C1 3 
#define SPI_SS_AD9854_C2 99 

struct spi_device ssid[SPI_SLAVE_CNT];

config.c:

#include "config.h" 

struct spi_device ssid[SPI_SLAVE_CNT] =
{
  { SPI_SS_ADF4350_C1 },
  { SPI_SS_ADF4350_C2 },
  { SPI_SS_AD9854_C1 },
  { SPI_SS_AD9854_C2 } 
};

Please show a bit more context; pehaps an include is missing somewhere? — Codor
– Codor, Commented May 8, 2014 at 7:29
show us the declaration of array of struct serviceStructs in the file config.h — ajay
– ajay, Commented May 8, 2014 at 7:31
the struct declaration in the service.h typedef uint32_t board_spi_select_id_t; struct spi_device { //! Board specific select id board_spi_select_id_t id; }; the config.h file #include "service.h #define SPI_SLAVE_COUNT 4 #define SPI_SS_ADF4350_C1 0 #define SPI_SS_ADF4350_C2 99 #define SPI_SS_AD9854_C1 3 #define SPI_SS_AD9854_C2 99 struct spi_device ssid[SPI_SLAVE_CNT]; the config.c file #include config.h spi_device_t spi_ss_id[4] = {{SPI_SS_ADF4350_C1}, {SPI_SS_ADF4350_C2},{ SPI_SS_AD9854_C1},{SPI_SS_AD9854_C2}}; — luyts.m
– luyts.m, Commented May 8, 2014 at 8:05
Do not significantly change your question after answers had been posted, as those edits might make certain answers un-understandable. Just add more to your answer without deleting what there was. — alk
– alk, Commented May 8, 2014 at 11:08

alk · Accepted Answer · 2014-05-08 11:06:35Z

2

In config.c

spi_device_t

is unknown.

Either use struct sp_device instead of spi_device_t

struct spi_device spi_ss_id[4] =  
{
  ...

or declare the latter, for example by adding

typedef struct spi_device spe_device_t;

at the end of service.h.

edited May 8, 2014 at 11:06

answered May 8, 2014 at 8:42

alk

71.2k10 gold badges112 silver badges274 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Jongware Over a year ago

So include service.h in config.h (and not in the main program).

alk Over a year ago

@Jongware That's what the OP seems to be doing.

Jongware Over a year ago

Ah, you're right -- I got lost in the order of includes and defines. spi_device_t is simply not defined anywhere. gcc reports error: expected specifier-qualifier-list before 'board_spi_select_id_t'

luyts.m Over a year ago

@alk Sorry, it was copied wrong, I used both methods you described but without succes. The error array type has incomplete element type hits on the line where i define the the array in my header file. I edited the original post. When i declare the the array only in the config.c file it compiles without error. So i dont think its an include problem

lethal-guitar · Accepted Answer · 2014-05-08 09:33:08Z

0

You are defining SPI_SLAVE_COUNT, but in the array definition you use SPI_SLAVE_CNT - notice the different spelling.

If I change this, it compiles fine for me with both gcc and clang.

answered May 8, 2014 at 9:33

lethal-guitar

4,5291 gold badge22 silver badges42 bronze badges

Collectives™ on Stack Overflow

Creating an array of structs defined in another header file

2 Answers 2

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related