Ruby: If statements giving "undefined method" error

Question

I've recently been trying to learn ruby using Learn to Program by Chris Pine, and at chapter 10 he gives a recursive code for counting continent size

M = 'land'
O = 'water'

world = [[O, O, O, M, O, O, O, O], 
         [O, O, M, M, O, O, M, O], 
         [M, M, M, M, M, O, O, M], 
         [M, M, O, M, O, O, O, O],
         [O, M, M, M, M, O, O, O],
         [O, O, M, M, O, M, M, M], 
         [O, O, M, O, O, O, O, O]]

def continent_size world, x, y
    if world[y][x] != M
        return 0
    end

    size = 1
    world[y][x] = 'counted'

    size += continent_size world, x-1, y-1
    size += continent_size world, x, y-1
    size += continent_size world, x+1, y-1
    size += continent_size world, x-1, y
    size += continent_size world, x+1, y
    size += continent_size world, x-1, y+1
    size += continent_size world, x, y+1
    size += continent_size world, x+1, y+
    size
end
puts continent_size world, 5, 5

in the book he states that this code would give errors if some of the land is attached to the edge (which, as you can see, I tried), but the code runs just fine. When I did try adding very simple checks, as in:

def continent_size world, x, y
    if y < 0
        return 0
    end
    if world[y][x] != M
        return 0
    end
    .
    .

suddenly I get "undefined method '[]' for nil:NilClass" error on "if world[y][x] != M" line and I really have no idea what have changed to cause this. Where is this error coming from?

edit: after some testing it does seem like the problem now is with the numbers being out of bound, since the following does work:

def continent_size (world, x, y)
    if y < 0 || y > 6 || x < 0 || x > 7
        return 0
    end
    if world[y][x] != M
        return 0
    end
    .
    .

I'm still confused as to why the original code worked with no problems though

On which line does that error come?

Pavan
– Pavan

2014-05-13 08:31:40 +00:00
Commented May 13, 2014 at 8:31 — Pavan
– Pavan, Commented May 13, 2014 at 8:31
on the "if world[y][x] != M"

Nescio
– Nescio

2014-05-13 08:32:18 +00:00
Commented May 13, 2014 at 8:32 — Nescio
– Nescio, Commented May 13, 2014 at 8:32
It should be def continent_size(world,x,y) i guess.

Pavan
– Pavan

2014-05-13 08:33:54 +00:00
Commented May 13, 2014 at 8:33 — Pavan
– Pavan, Commented May 13, 2014 at 8:33
still gives the same error

Nescio
– Nescio

2014-05-13 08:35:16 +00:00
Commented May 13, 2014 at 8:35 — Nescio
– Nescio, Commented May 13, 2014 at 8:35

BroiSatse · Accepted Answer · 2014-05-13 08:38:42Z

1

You have the problem with edges, if your world is 5x5 then you are calling world[6][6] against it (negative numbers still works). world[6] return nil, which does not define [] method.

To fix it, you need to add:

def continent_size world, x, y
  if y < 0 || world[y].nil? || world[y][x] != M
    return 0
  end

answered May 13, 2014 at 8:38

BroiSatse

44.8k8 gold badges63 silver badges89 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Nescio Over a year ago

Thanks! It's pretty much what I thought, but why does the original code without the check does work then? And how exactly do negative numbers work with arrays?

BroiSatse Over a year ago

It shouldn't and it doesn't, at least in my irb. Can you try running it again?

Nescio Over a year ago

Well now it doesn't... I have to say I'm thoroughly confused

Collectives™ on Stack Overflow

Ruby: If statements giving "undefined method" error

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related