jQuery variable inside .each() function

Question

I have this piece of code

var temp = "text " + this.link + " text";

$(data.query.results.item).each(function () {
    alert(temp);
});

When alerted it returns "text undefined text"

But if i do this

$(data.query.results.item).each(function () {
    alert("text " + this.link + " text");
});

It returns the correct value

Why is this happening and how can i get it to work?

Thanks

if temp is a global variable then this would refer to the window object. — Rohit416
– Rohit416, Commented May 21, 2014 at 7:24

hsz · Accepted Answer · 2014-05-21 07:21:47Z

1

this.link is not accessible from the outside of the each loop. You can get access this context only from teh each scope. If you want to define some "template" ouside of the loop, you can try with:

var temp = "text %link% text";

$(data.query.results.item).each(function () {
    alert(temp.replace('%link%', this.link));
});

answered May 21, 2014 at 7:21

hsz

153k63 gold badges268 silver badges320 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Rajaprabhu Aravindasamy Over a year ago

what if that .each has been wrapped around another one .each ..?

DimitrisBor Over a year ago

So what if i wante to put in the template more, like var temp = "text %link% text %image% text %title%". How can i replace all these without declaring this.link, this.image, this.title inside each.

hsz Over a year ago

@DimitrisBorbotsialos You have to bound key %...% with value this...., so for text %link% text %image% text %title% it should be temp.replace('%link%', this.link).replace('%image%', this.image).replace('%title%', this.title)

DimitrisBor Over a year ago

Thanks for your time. The thing is that i tried to use John Resig's micro template engine for this purpose. I've posted the original question but no answer yet here: stackoverflow.com/questions/23757090/… If you have the time take a look of what i try to accomplish. Thanks again

Adil Shaikh · Accepted Answer · 2014-05-21 07:23:15Z

1

this refer to the context/scope where it is executed, your this is executed outside of each, that is why it is undefined -

You can try something like this -

function getText(item){
  var temp = "text " + item.link + " text";
}

$(data.query.results.item).each(function () {
    alert(getText(this));
});

answered May 21, 2014 at 7:23

Adil Shaikh

44.8k17 gold badges95 silver badges112 bronze badges

3 Comments

hsz Over a year ago

I would go further and pass only this.link to the getText function.

Adil Shaikh Over a year ago

@hsz sure, but item may have another properties that OP might want to include in text (in future)

hsz Over a year ago

On the other hand - it cannot be used for other kind of item. We can only speculate. ;-)

Deepu--Java · Accepted Answer · 2014-05-21 07:22:23Z

0

Because this always refers to the current object.

var temp = "text " + this.link + " text";

Here this is undefined that's why it's showing that message.

answered May 21, 2014 at 7:22

Deepu--Java

3,8403 gold badges21 silver badges31 bronze badges

Comments

Waqar Alamgir · Accepted Answer · 2014-05-21 07:29:54Z

0

Why not use each method in this way!

$.each(data.query.results.item, function( index, value ) {
    alert( "text " + value.link );
});

answered May 21, 2014 at 7:29

Waqar Alamgir

9,9884 gold badges33 silver badges37 bronze badges

Collectives™ on Stack Overflow

jQuery variable inside .each() function

4 Answers 4

4 Comments

3 Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

4 Comments

3 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related