TreeView from database with null

Question

I have som problem populating a treeview in c# from database. The table looks like this:

| code    | description | attached to | 
---------------------------------------
| P001    | TEST001     | NULL        |
| P0001   | TEST002     | P001        |
| P002    | TEST003     | NULL        |
| P00201  | TESTXXX     | P002        |
| P00222  | TESTXXX     | P002        |
| P002020 | TESTSSS     | P00222      |

This does not work.

protected void PopulateTreeView(TreeNodeCollection parentNode, string parentID, DataTable folders)
    {

        foreach (DataRow folder in folders.Rows)
        {
            // if (Convert.ToInt32(folder["Attached to"]) == parentID)
            if (string.IsNullOrEmpty(folder["Attached to"].ToString()))
            {

                String key = folder["code"].ToString();
                String text = folder["description"].ToString();
                TreeNodeCollection newParentNode = parentNode.Add(key, text).Nodes;
                //PopulateTreeView(newParentNode, Convert.ToInt32(folder["code"]), folders);
                PopulateTreeView(newParentNode, folder["code"].ToString(), folders);
            }
        }
    }

Why does it not work? Error, invalid node, something else? Please explain what the problem is. — DonBoitnott
– DonBoitnott, Commented May 28, 2014 at 12:16
Recursion method always starts from the first row and then call itself in loop. Well, in your example it stuck on second row. — Igos
– Igos, Commented May 28, 2014 at 12:21

Igos · Accepted Answer · 2014-05-28 13:31:06Z

1

The problem is with your If condition. You should search for rows that are attached to parentID. Here is corrected method with test:

    public void Test_PopulateTreeViews()
    {
        var rootNode = new TreeNode();
        var folders = new DataTable();

        folders.Columns.Add("code");
        folders.Columns.Add("description");
        folders.Columns.Add("Attached to");
        folders.Rows.Add("P001", "TEST001", string.Empty);
        folders.Rows.Add("P0001", "TEST002", "P001");
        folders.Rows.Add("P002", "TEST003", null);
        folders.Rows.Add("P00201", "TEST003", "P002");
        folders.Rows.Add("P00222", "TESTXXX", "P002");
        folders.Rows.Add("P002020", "TESTSSS", "P00222");

        PopulateTreeView(rootNode, string.Empty, folders);
    }

    private void PopulateTreeView(TreeNode parentNode, string parentID, DataTable folders)
    {
        foreach (DataRow folder in folders.Rows)
        {
            if (folder["Attached to"].ToString() == parentID)
            {
                String key = folder["code"].ToString();
                String text = folder["description"].ToString();

                var newParentNode = new TreeNode(key, text);
                parentNode.ChildNodes.Add(newParentNode);
                PopulateTreeView(newParentNode, folder["code"].ToString(), folders);
            }
        }
    }
});

edited May 28, 2014 at 13:31

answered May 28, 2014 at 12:32

Igos

2111 silver badge3 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Gmorken Over a year ago

sorry but this does not work. infinite loop. Maybe I was unclear. The table does not have null values in attached to. The attached field is blank when there is no parent

Igos Over a year ago

I corrected the code so it could be compiled and tested. But main idea remains. As far as I saw resutls it creates tree correctly.

Collectives™ on Stack Overflow

TreeView from database with null

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related