PHP properties overloading

Question

What's wrong with the following code?

$inFile and $outFile get initialized ALWAYS by machine1 and not by machine2, which means that with an instance of machine2 the config of machine1 gets opened (and written).

What am I doing wrong? I understood that $this->somevar refers to the object actually instantiated (machine2).

Thanks.

class machine1
{
    private  $inFile = "Config.ini";
    private  $outFile = "Config.web";
    
    public $fileArray = array();
    
    
    public function LoadData()
    {
        $handle = fopen(paths::$inifiles . $this->inFile,"r");
        // Read the file
        fclose($handle);
    }
    
    public function SaveData()
    {
        $handle = fopen(paths::$inifiles . $this->outFile,"w");
        //write the file
        fclose($handle);
    }
}
class machine2 extends machine1
{
    private  $inFile = "Config_1.ini";
    private  $outFile = "Config_1.web";
}

$obj = new machine2();
$obj->LoadData();
$obj->SaveData();

Community · Accepted Answer · 2017-05-23 10:33:20Z

3

You're using private for the variables. That means that child classes cannot inherit them, use them, or redefine them.

Try changing them to protected and I bet it works. You can read more about them in this thread: https://stackoverflow.com/a/4361582/2370483

edited May 23, 2017 at 10:33

CommunityBot

11 silver badge

answered Jun 17, 2014 at 16:15

Machavity♦

31.8k27 gold badges97 silver badges108 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

user399666 · Accepted Answer · 2014-06-17 16:18:32Z

1

Make them protected instead of private.

protected $inFile = "Config.ini";
protected $outFile = "Config.web";

edited Jun 17, 2014 at 16:18

answered Jun 17, 2014 at 16:12

user399666

20k7 gold badges49 silver badges68 bronze badges

Comments

Mateusz Odelga · Accepted Answer · 2014-06-17 16:20:53Z

1

The best solution should be initializing those variables using constructor. e.g

in machine1:
public function __construct($inFile="Config.ini",$outFile="Config.web"){
    $this->inFile= $inFile;
    $this->outFile= $outFile;
}

in machine2:
public function __construct(){
    parent::__construct("Config_1.ini","Config1.web");
}

answered Jun 17, 2014 at 16:20

Mateusz Odelga

3542 silver badges7 bronze badges

Collectives™ on Stack Overflow

PHP properties overloading

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related