AngularJS : Service not Returning Variables to Controllers

Question

My app has a service that is supposed to return an array of objects (tweets from the twitter api) that looks like:

.service('twitterService', function($http) {
    this.getTweets = function(){
        $http.get('http://example.com/?json=get_twitter_sidebar').success(
            function(data, status, headers, config) {
                if (data.status == 'ok') {
                    return data.feed;
                } else {
                    return 'Error Retrieving Feed'
                }
            });
    }

})

This service seems to work; it calls the api and returns the desired object array (I used console.log to verify). However, I can't seem to pass the returned array to my controller:

var TopPageCtrl = function($scope, $window, $http, twitterService) {
    $scope.feed = twitterService.getTweets();
};

When I use console.log($scope.feed), it returns undefined. I've tried a million approaches but nothing seems to work. What am I doing wrong?

James · Accepted Answer · 2014-06-30 17:42:49Z

2

return the promise

.service('twitterService', function($http) {
this.getTweets = function(){
    var p = $http.get('http://example.com/?json=get_twitter_sidebar').success(
        function(data, status, headers, config) {
            if (data.status == 'ok') {
                return data.feed;
            } else {
                return 'Error Retrieving Feed';
            }
        });
     return p;
}});


var TopPageCtrl = function($scope, $window, $http, twitterService) {
twitterService.getTweets().then(function (response) {
  $scope.feed = response;
};};

answered Jun 30, 2014 at 17:42

James

3861 gold badge4 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

tarrball · Accepted Answer · 2014-06-30 17:39:55Z

1

Maybe it's returning a promise that needs to be resolved? Try something like...

var getFeed = twitterService.getTweets();
getFeed.then(function (feed) {
    $scope.feed = feed;
});

answered Jun 30, 2014 at 17:39

tarrball

2,3563 gold badges26 silver badges38 bronze badges

Comments

Rodrigo Fonseca · Accepted Answer · 2014-06-30 17:43:03Z

$scope.feed = twitterService.getTweets();

this.getTweets = function(){
            $http.get('http://example.com/?json=get_twitter_sidebar').success(
                function(data, status, headers, config) {
                    if (data.status == 'ok') {
                        return data.feed;
                    } else {
                        return 'Error Retrieving Feed'
                    }
                });
        }

Your function isn´t returning anything, that´s why you are getting "undefined".. Try this:

this.getTweets = function(){
                return $http.get('http://example.com/?json=get_twitter_sidebar').success(
                    function(data, status, headers, config) {
                        if (data.status == 'ok') {
                            return data.feed;
                        } else {
                            return 'Error Retrieving Feed'
                        }
                    });
            }

twitterService.getTweets().then(function (response){...});

Collectives™ on Stack Overflow

AngularJS : Service not Returning Variables to Controllers

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related