Groovy Array.addAll method remove the elements from original array

Question

Ok I'm sure I'm doing something wrong here.

result = []
for (aMp in arMap)  {
    println("0 " + result)
    println("1 " + aMp)
    println("2 " + delegate.findSingleMap(aMp))
    result.addAll(delegate.findSingleMap(aMp))
    println "3 " + result
}
return result

The println result are the following: (I have 2 element in arMap, so it print the four value 2 times)

0 []
1 [ID:XXX, Type:4]
2 [[First:21/Nov/2013,  Type:4, error code:SXR07, ID:XXX, Test ID:5]]
3 [[First:21/Nov/2013,  Type:4, error code:SXR07, ID:XXX, Test ID:5]]
0 [[First:21/Nov/2013,  Type:4, error code:SXR07, ID:XXX, Test ID:5]]
1 [ID:YYY, Type:4]
2 [[First:12/Oct/2012,  Type:4, error code:SXR07, ID:YYY, Test ID:6]]
3 [[First:12/Oct/2012,  Type:4, error code:SXR07, ID:YYY, Test ID:6]]

As you can see the findSingleMap function work properly, but the second time I use the AddAll, my result array loose the value XXX.

What am I doing wrong?

You post not all you code. Where string that starts from 0 come from? — talex
– talex, Commented Sep 19, 2014 at 10:44
@talex just added. I was wondering if the result reset before the beginning of next cycle and I added a print — SeraphimFoA
– SeraphimFoA, Commented Sep 19, 2014 at 10:44
does your findSingleMap also work with a variable result? Using a simplified version of your code works fine for me (groovy 2.2.1) and addAll works as advertised. — cfrick
– cfrick, Commented Sep 19, 2014 at 11:20
@cfrick You got it right. Want to turn it into an answer? My findSingleMap was result = delegate for (aEl in map) { result = result.findAll({ it[aEl.key] == aEl.value }) } return result — SeraphimFoA
– SeraphimFoA, Commented Sep 19, 2014 at 11:26
@cfrick I'm still quite young in groovy scripting and I'm loosing sight of scope of variable all the time!!! — SeraphimFoA
– SeraphimFoA, Commented Sep 19, 2014 at 11:29

dmahapatro · Accepted Answer · 2014-09-19 14:43:36Z

1

As stated by the OP int the comments the method findSingleMap modifies the (global) result variable.

for (aEl in map) { 
    result = result.findAll { it[aEl.key] == aEl.value } 
}

return result

Not writing def in front a variable declares it (in simple scripts) global, which might result in strange behaviour like this. So don't do it, unless you have to codegolf.

edited Sep 19, 2014 at 14:43

dmahapatro

50.4k7 gold badges94 silver badges122 bronze badges

answered Sep 19, 2014 at 11:36

cfrick

37.3k7 gold badges61 silver badges76 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Groovy Array.addAll method remove the elements from original array

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related