html onClick open url stored in a php variable

Question

Following is my code, am getting Uncaught SyntaxError: Unexpected token }, but i don't see any } in my code. window.open is expecting url in quotes, I tried different combinations of single and double quotes but not working and unable to escape the double quote in echo either.Please help

Thanks..

<?php
$a = "https://www.google.co.in/";

?>

<html>
<body>
<form>

<input type="button" width="100" onClick="window.open(<?php echo '"'; echo $a; echo '"'; ?>)" height="100%" value="Edit Record"/>

</form>
</body>
</html>

To determine where the problem is, look at your JavaScript and HTML, not at your PHP. — Quentin
– Quentin, Commented Oct 24, 2014 at 7:21

Quentin · Accepted Answer · 2014-10-24 07:22:24Z

1

You are outputting " characters into your onClick attribute value. Since you use those characters to delimit the value, the first one ends the script in the middle of the statement.

Use " instead.

But that's a quick and dirty hack. There are better approaches.

Do not try to generate JavaScript strings by mashing PHP strings together. Use a robust escaping function. json_encode will give you the JavaScript literal (including quote characters where needed) for any simple data structure.
Do not try to generate HTML by mashing strings together. Use a robust escaping function. htmlspecialchars will do all you need.

Such:

onClick="window.open(<?php echo htmlspecialchars(json_encode($a)); ?>)"

But don't use JavaScript when HTML will do:

<a href="<?php echo htmlspecialchars($a); ?>" target="_blank">

answered Oct 24, 2014 at 7:22

Quentin

949k136 gold badges1.3k silver badges1.4k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Aviator · Accepted Answer · 2014-10-24 07:36:53Z

0

You should use echo "'$a'". The main problem is that you would habe double-double quotes in your onclick attribute. Or even better window.open('<?php echo $a; ?>').

edited Oct 24, 2014 at 7:36

answered Oct 24, 2014 at 7:24

Aviator

5323 silver badges7 bronze badges

Collectives™ on Stack Overflow

html onClick open url stored in a php variable

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related