Combining ArrayList without duplicates

Question

import java.util.ArrayList;
import java.util.Collections;

public class SmartCombining {
    public static void main(String[] args) {
        ArrayList<Integer> list1 = new ArrayList<Integer>();
        ArrayList<Integer> list2 = new ArrayList<Integer>();

        Collections.addAll(list1, 4, 3);
        Collections.addAll(list2, 5, 10, 4, 3, 7);

        smartCombine(list1, list2);
        System.out.println(list1);
        System.out.println(list2);
    }

    public static void smartCombine(ArrayList<Integer> first,
            ArrayList<Integer> second) {
        first.addAll(second);
    }    
}

So, I want to combine two lists into one, but if the second list contains a number from the first it won't be added. So far my method adds them all together.

If you don't want duplicate values use a set, e.g. a TreeSet<Integer> — Martin
– Martin, Commented Oct 28, 2014 at 19:01

nem035 · Accepted Answer · 2014-10-28 19:11:56Z

7

Well, one way to do it is to iterate through the second list while checking if each element exists in the first list. If it doesn't, add it.

public static void smartCombine(ArrayList<Integer> first, ArrayList<Integer> second) {
     for(Integer num : second) {      // iterate through the second list
         if(!first.contains(num)) {   // if first list doesn't contain current element
             first.add(num);          // add it to the first list
         }
     }
}

Another way would be for you to hold your values inside a set (like HashSet) which doesn't allow any duplicates. Then you can combine them like:

first.addAll(second);

One more way you could do it is to first remove all elements from the first list that exist in the second list (the ones that would be duplicated). Then you add all elements of the second list to the first list.

public static void smartCombine(ArrayList<Integer> first, ArrayList<Integer> second) {
    first.removeAll(second); // remove elements that would be duplicated
    first.addAll(second);    // add elements from second list
}

edited Oct 28, 2014 at 19:11

answered Oct 28, 2014 at 19:00

nem035

35.5k6 gold badges93 silver badges104 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Mr. Polywhirl Over a year ago

I don't think OP wants to modify the second list, only the first. Flip that logic around.

nem035 Over a year ago

@Mr.Polywhirl yes, you are right, minor change, just did it

Gil Tzadikevitch · Accepted Answer · 2014-10-28 19:04:43Z

4

The simple, no brains solution:

Set<Integer> joinedSet = new HashSet<Integer>();
joinedSet.addAll(list1);
joinedSet.addAll(list2);

answered Oct 28, 2014 at 19:04

Gil Tzadikevitch

1872 bronze badges

Comments

JosEduSol · Accepted Answer · 2014-10-28 19:10:08Z

3

Remove duplicates, then merge both lists:

list1.remove(list2);
list1.addAll(list2);

If you dont want to alter the original list, then first create a backup:

list1BP = new ArrayList(list1);

Another approach is to use HashSet, see other answers.

edited Oct 28, 2014 at 19:10

answered Oct 28, 2014 at 19:04

JosEduSol

5,4884 gold badges25 silver badges34 bronze badges

1 Comment

Mr. Polywhirl Over a year ago

Looks like people agree with you: List intersection in java.

ToYonos · Accepted Answer · 2014-10-28 19:05:54Z

2

Use Set, it has been created for that purpose. A Set cannot contain 2 identical elements, based on the equals method.

Set<Integer> list1 = new HashSet<Integer>();
Set<Integer> list2 = new HashSet<Integer>();

Using a combination of ArrayList and contains method is an antipattern here.

answered Oct 28, 2014 at 19:05

ToYonos

16.9k3 gold badges62 silver badges74 bronze badges

1 Comment

Dogcat Over a year ago

The whole point of using lists is to have ORDERED collections. If you switch to HashSet, you loose that. Maybe your answer would be better with LinkedHashSets or something.

user7969045 · Accepted Answer · 2017-06-25 15:18:15Z

There are two easy way you can combine two Lists and duplicate will be removed.

1) First and very easiest way you can get your output, by creating equivalent HashSet object of your ArrayList. Since HashSet does not allow duplicates.

public static void main(String[] args) {
    ArrayList<Integer> list1 = new ArrayList<Integer>();
    ArrayList<Integer> list2 = new ArrayList<Integer>();

    Collections.addAll(list1, 4, 3);
    Collections.addAll(list2, 5, 10, 4, 3, 7);
    System.out.println(smartCombine(list1, list2));
}
public static HashSet<Integer> smartCombine(ArrayList<Integer> first, ArrayList<Integer> second) {
    first.addAll(second);
    HashSet<Integer> hs = new HashSet<Integer>(first);
    return hs;

2) There is another way using advanced for loop. Iterate the second list and check if the current element is not in first list and then add the current element.

public static void main(String[] args) {
    ArrayList<Integer> list1 = new ArrayList<Integer>();
    ArrayList<Integer> list2 = new ArrayList<Integer>();
    Collections.addAll(list1, 4, 3);
    Collections.addAll(list2, 5, 10, 4, 3, 7);
    smartCombine(list1, list2);
    System.out.println(list1);
}
public static void smartCombine(ArrayList<Integer> first, ArrayList<Integer> second) {
    for (Integer num : second) {
        if (!first.contains(num)) {
            first.add(num);
        }
    }
}

Note: The second way will work fine only if first list has no duplicates.

Chiseled · Accepted Answer · 2014-10-28 19:03:34Z

0

Have you tried ArrayList.addAll()

Look at this java doc

As pointer out this would not handle duplicates which can easily be removed using a Set

answered Oct 28, 2014 at 19:03

Chiseled

2,2968 gold badges37 silver badges61 bronze badges

2 Comments

Mr. Polywhirl Over a year ago

Does not handle duplicates.

Chiseled Over a year ago

i agree it does not. Logic for that will have to be written separately

Salih Erikci · Accepted Answer · 2014-10-28 19:10:42Z

0

use contains(Object) method in ArrayList

public static void smartCombine(ArrayList<Integer> first,
        ArrayList<Integer> second) {
    for(Integer i :second){
       if(!first.contains(i)) { // if first list doesn't contain this item, add item to the first list.
          first.add(i);
       }
    }
}

edited Oct 28, 2014 at 19:10

answered Oct 28, 2014 at 18:59

Salih Erikci

5,09513 gold badges43 silver badges71 bronze badges

Collectives™ on Stack Overflow

Combining ArrayList without duplicates

7 Answers 7

2 Comments

Comments

1 Comment

1 Comment

Comments

2 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

7 Answers 7

2 Comments

Comments

1 Comment

1 Comment

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related