Checking for int in int array

Question

I'm trying to find an integer inside of an int[] array and return true or false depending on whether or not it's present anywhere, however my code, which I've taken from numerous websites.

My array is as follows:

private static final int[] thirtyOneDays = {1, 3, 5, 7, 8, 10, 12};

And I'm searching it like so:

Arrays.asList(thirtyOneDays).contains(month)

Where month is an integer.

When debugging the program all the variables and fields are set correctly as expected, it just always returns false. Does anyone know why this is?

As for month, it originates from a JTextField on my GUI:

new Validate(txtDay.getText(), txtMonth.getText(), txtYear.getText());

Here's the Validate constructor:

public Validate(String day, String month, String year)
{
    instance = this;

    if(this.isYearValid(year))
    {
        if(this.isMonthValid(month, year))
        {
            if(this.isDayValid(day, month, year))
            {
                isAllValid = true;
            }
        }
    }
}

And here's the very top of isDayValid():

private boolean isDayValid(String dayS, String monthS, String yearS)
{
    int year = Integer.parseInt(yearS);
    int month = Integer.parseInt(monthS);
    int day = Integer.parseInt(dayS);

~~~~~~~ P.S. What's the difference between:

int[] intArray = {1, 2, 3}
int[] intArray = new int{1, 2, 3, 4}
Integer[] intArray = new Integer{1, 2, 3, 4}

@SirRichie it's inputted by the user and then fed to the constructor of another class where it's fed to this method and converted from string to integer (successfully) — Jake Stanger
– Jake Stanger, Commented Nov 18, 2014 at 17:46

Reimeus · Accepted Answer · 2014-11-18 20:43:43Z

3

Arrays.asList(thirtyOneDays) returns a List containing a single entry of type int[] which is different from any of the integers in the original List.

edited Nov 18, 2014 at 20:43

answered Nov 18, 2014 at 17:42

Reimeus

160k16 gold badges225 silver badges282 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Jake Stanger Over a year ago

Could you explain this in more depth please? My knowledge around arrays is pretty weak.

JohnnyAW Over a year ago

maybe you should add for clarification, that return type of asList will be List<int[]> an not List<Integer> in this case

SirRichie Over a year ago

Wow, I never noticed this subtle detail - definitely deserves an upvote.

James Hutchinson · Accepted Answer · 2014-11-18 17:57:18Z

2

Try this instead:

    for(int x:thirtyOneDays) {
        if (x == month) {
            return;
        }
    }

You are trying to compare an array of integers with a single integer. So it's a bit like saying is this pen like this group of ten pens. The answer is always going to be no.

Regarding this bit:

int[] intArray = {1, 2, 3}
int[] intArray = new int{1, 2, 3, 4}
Integer[] intArray = new Integer{1, 2, 3, 4}

int is a base type that you can't call methods on, whereas Integer is a wrapper class that allows you to essentially call methods.

I'm not sure what the difference between the first two lines is, but I suspect it concerns how Java allocates memory.

edited Nov 18, 2014 at 17:57

answered Nov 18, 2014 at 17:51

James Hutchinson

8913 gold badges14 silver badges29 bronze badges

1 Comment

Jake Stanger Over a year ago

Thanks. This answer is quite simple and easy to understand and worked straight away.

Jörg Bächtiger · Accepted Answer · 2014-11-18 17:50:00Z

0

int[] is an array of primitvs. Where Integer[] is an array of Integer objects. Thus it size is different. It is not the same type at all.

answered Nov 18, 2014 at 17:50

Jörg Bächtiger

1302 silver badges4 bronze badges

Comments

eyebleach · Accepted Answer · 2014-11-18 17:58:12Z

0

Or try this. With a while-loop and a boolean expression you don't have to iterate thru the whole array.

boolean match = false;
int index = 0;
while(!match && index < thirtyOneDays.length) {
    if(thirtyOneDays[index] == month) {
        match = true;

        //do what u want with the matching int
    }
index++;
}

answered Nov 18, 2014 at 17:58

eyebleach

3383 silver badges6 bronze badges

Collectives™ on Stack Overflow

Checking for int in int array

4 Answers 4

3 Comments

1 Comment

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

3 Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related