Multiple checkbox database insert with mysql prepare

Question

I have checkboxes generated with this code:

while($row = $result->fetch_assoc()) {
    echo "<input type='checkbox' name='branch[]' value='".$row['id']."'> ".$row['name']."<br>";
}

And I need to insert value of every checkbox in mysql database. Code that I have inserts it for every checkbox but only $member_id, $branch is always inserted as 0. What am I doing wrong?

$sql = "SELECT id FROM members WHERE email='$email'";
$result = mysqli_query($mysqli,$sql);
$row = mysqli_fetch_array($result,MYSQLI_ASSOC);
$member_id = $row["id"];
$checked_arr = $_POST['branch'];
$branch_count = count($checked_arr);
for ($i = 0; $i < $branch_count; $i++) {
    if ($insert_stmt_branch = $mysqli->prepare("INSERT INTO members_branch (member, branch) VALUES (?, ?)")){         
    $insert_stmt_branch->bind_param('ss', $member_id, $branch);

        if (! $insert_stmt_branch->execute()) {
            echo "ERROR: branch insert";
        }
    }
}

check the fetched array from where you are getting the values of $member_id and $branch. var_dump($row) — Aditya
– Aditya, Commented Dec 5, 2014 at 18:23
$branch in $insert_stmt_branch->bind_param('ss', $member_id, $branch); does not exist. You want to use $checked_arr[$i] -> $insert_stmt_branch->bind_param('ss', $member_id, $checked_arr[$i]); — Sean
– Sean, Commented Dec 5, 2014 at 18:23
You probably should prepare your SQL outside the loop, so you can reuse it. — Quentin
– Quentin, Commented Dec 5, 2014 at 18:23

Brandon Rohde · Accepted Answer · 2014-12-05 18:25:00Z

1

At the start of your for loop, you forgot to add:

$branch = $checked_arr[$i];

Also, you don't have anything to verify that your query looking up by email address returns a value. If no account is found, your $member_id value will be blank.

answered Dec 5, 2014 at 18:25

Brandon Rohde

3181 gold badge3 silver badges11 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Quentin · Accepted Answer · 2014-12-05 18:22:54Z

1

You never assign a value to $branch

answered Dec 5, 2014 at 18:22

Quentin

949k136 gold badges1.3k silver badges1.4k bronze badges

Collectives™ on Stack Overflow

Multiple checkbox database insert with mysql prepare

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related