Storing DOM reference elements in a Javascript array

Question

Dear experts, I was trying to dynamically generate DOM elements using JS.

I read from Douglas Crockford's book that DOM is very very poorly structured.

Anyways, I would like to create a number of DIVISION elements and store the reference into an array so it could be accessed later.

Here's the code

for(i=0; i<3; i++) {
    var div = document.body.appendChild(document.createElement("div"));
    var arr = new Array();
    arr.push(div);
}

Somehow this would not work..... There is only 1 div element created. When I use the arr.length to test the code there is only 1 element in the array.

Is there another way to accomplish this?

Thanks in advance

The best way to thank someone is to accept their answer. Someone had to say it :) — alex
– alex, Commented May 24, 2010 at 0:00

alex · Accepted Answer · 2011-01-30 14:50:33Z

16

You are recreating the array with each iteration (and thus blanking it).

I think you want something like this.

var arr = []; // more succinct version of new Array();

for (var i = 0; i < 3; i++) {
    var div = document.body.appendChild(document.createElement('div'));
    arr.push(div);        
};

edited Jan 30, 2011 at 14:50

answered May 23, 2010 at 23:52

alex

492k205 gold badges890 silver badges992 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Warty Over a year ago

@webzide, don't forget to click the check button next to alex's post so he gets credit!

SLaks · Accepted Answer · 2010-05-23 23:52:40Z

3

You're making a separate array each time the loop runs.
Therefore, each array instance

You need to move the arr variable outside the loop.

answered May 23, 2010 at 23:52

SLaks

891k182 gold badges1.9k silver badges2k bronze badges

Collectives™ on Stack Overflow

Storing DOM reference elements in a Javascript array

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related