Adding items to an existing dictionary using loops in python

Question

I want the output to be in the form:

dic = {size1:file/path1, size2:file/path2}

But what I am getting in individual dictionaries for each combination, like:

{size1:file/path1}
{size2:file/path2, size1:file/path1, ...}

This is the code I came up with, can anyone correct my code.

import os, subprocess, re, sys
records = {}
out = sys.stdout
with open('PythonFilesInMac.txt', 'w') as outfile:
     sys.stdout = outfile
     for cdir, dir, files in os.walk(r'/Users'):
         for file in files:
             if file.endswith('.py'):
                filename = os.path.join(cdir, file)
                size = os.path.getsize(filename)
                records[size] = filename #records = {size:filename}
                print records             #how do I use dict.update() here?   
     sys.stdout = out

You are getting all of the combinations because you are printing out records in every loop. — Tim McNamara
– Tim McNamara, Commented May 17, 2015 at 5:23
your code seems correct, do a print records after your loop to check that it is indeed correct — Julien Spronck
– Julien Spronck, Commented May 17, 2015 at 5:26
if two files have the same size, this code will silently overwrite the first. — Tim McNamara
– Tim McNamara, Commented May 17, 2015 at 5:30

Xiaotian Pei · Accepted Answer · 2015-05-17 05:28:23Z

1

there are two problems in your code. the first is you should put print outside your loop. the second is there may be two files with same size, better to put them in a list.

import os, subprocess, re, sys
records = {}
out = sys.stdout
with open('PythonFilesInMac.txt', 'w') as outfile:
     sys.stdout = outfile
     for cdir, dir, files in os.walk(r'/Users'):
         for file in files:
             if file.endswith('.py'):
                filename = os.path.join(cdir, file)
                size = os.path.getsize(filename)
                records.setdefault(size, []).append(filename)
     print records  
     sys.stdout = out

answered May 17, 2015 at 5:28

Xiaotian Pei

3,27023 silver badges41 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Adding items to an existing dictionary using loops in python

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related