Using a function and an array to get the maximum and minimum value

Question

I am having some trouble getting my program to find the maximum and minimum values for a set of students GPA's. I can do this easily without using a function but when I include the function my program still runs fine but it does not calculate the maximum and minimum GPA's. I have debugged it as well and by the looks of things the program simply runs straight over it without looking at it. Your help would be greatly appreciated. This is what my code currently looks like:

#include <iostream>
using namespace std;

float array(int arr[], int size)
{
    float max = 0;
    float min = 4;
    int i;

    for (i = 0; i <= 2; i++)
    {
        if (arr[i] > max)
            max = arr[i];

        if (arr[i] < min)
            min = arr[i];
    }
    cout << "Maximum GPA: " << max;
    cout << "Minimum GPA: " << min;

}
int main(int argc, char** argv)
{
    int ID[3];
    float GPA[3];
    int i;

    for (i = 0; i <= 2; i++)
    {
        cout << "Please enter student ID and GPA: " << endl;
        cin >> ID[i] >> GPA[i];
        array[GPA, i];
    }
    for (i = 0; i <= 2; i++)
    {
        cout << endl << "Student ID: " << ID[i] << endl << "Student GPA: " << GPA[i] << endl;
    }
    return 0;
}

"by the looks of things the program simply runs straight over it without looking at it" I don't understand why students keep jumping to this conclusion. — Lightness Races in Orbit
– Lightness Races in Orbit, Commented May 27, 2015 at 16:45
@LightnessRacesinOrbit I'm wondering how his program "ran fine" — dwcanillas
– dwcanillas, Commented May 27, 2015 at 16:46

dwcanillas · Accepted Answer · 2015-05-27 16:40:50Z

2

You are calling your function wrong:

array[GPA, i];

should be

array(GPA, i);

Your code shouldn't have even compiled, since I don't see an array variable.

There are also a few other things wrong with your code. array is probably a bad name for your function - meaningful function names are good practice, and std::array's existence can cause problems. size in your array function is unused, and as @jaggedSpire pointed out. Your array function should probably be

void array(float arr[], int size)

assumming you start using size.

edited May 27, 2015 at 16:40

answered May 27, 2015 at 16:32

dwcanillas

3,6802 gold badges27 silver badges35 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

jaggedSpire Over a year ago

Additionally, you are not returning a value from your array function, which should return a float, and you are taking an argument of an int array type into your array function, when the array you supply it with in your function call is of a float type. (float array(int arr[], int size) -> void array (float arr[], int size))

frendall · Accepted Answer · 2015-05-27 16:46:37Z

0

Hi I am quite new to programming but I think your function call array[GPA,i] should be array(GPA,i); and move it further down to just above return. its my first attempt at answering a question hope it helps.

answered May 27, 2015 at 16:46

frendall

636 bronze badges

Collectives™ on Stack Overflow

Using a function and an array to get the maximum and minimum value

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related