angular-ui-route resolve with angularJS factory

Question

I am trying to use the $stateProvider resolve with a factory I created

for some reason, the promise from the factory is an empty object

but when i log the data from the $http call, I get data from my .json file

any idea why my defer.promise is an empty object?

playlistsService.js

(function () {
    'use strict';

    angular
        .module('app.core')
        .factory('playlistsService', playlistsService);

    playlistsService.$inject = ['$http', '$q'];

    /* @ngInject */
    function playlistsService($http, $q) {
        var service = {
            loadPlaylists : loadPlaylists
        };

        return service;

        ////////////////

        function loadPlaylists() {
            var defer = $q.defer();
            $http.get('data/playlists.json')
                .success(function (data) {
                    console.log('json data: ' + angular.toJson(data));
                    defer.resolve(data);
                });
            console.log('defer.promise: ' + angular.toJson(defer.promise));
            return defer.promise;
        }
    }

})();

playlists.js

(function () {
    'use strict';

    angular
        .module('app.playlists')
        .config(stateProvider)
        .controller('Playlists', Playlists);

    stateProvider.$inject = ['$stateProvider'];
    Playlists.$inject = ['playlistsService'];

    /* @ngInject */
    function stateProvider($stateProvider){
        $stateProvider
            .state('app.playlists', {
                url: '/playlists',
                views: {
                    'menuContent': {
                        templateUrl: 'app/playlists/playlists.html',
                        controller: 'Playlists as vm',
                        resolve: {
                            playlists: function(playlistsService){
                                return playlistsService.loadPlaylists();
                            }
                        }
                    }
                }
            })
    }

    /* @ngInject */
    function Playlists(playlists) {
        /* jshint validthis: true */
        var vm = this;

        vm.activate = activate;
        vm.title = 'Playlists';
        vm.playlists = playlists;

        activate();

        ////////////////

        function activate() {
            console.log('playlists object: ' + angular.toJson(vm.playlists))
            console.log('playlists from service: ' + angular.toJson(playlists))
        }


    }

})();

Pankaj Parkar · Accepted Answer · 2015-07-18 19:41:18Z

2

Your Playlists controller should have $inject the playlists promise which has been created in resolve function instead of playlistsService will do the trick.

Playlists.$inject = ['playlists'];

Update

You could also utilize the promise created by $http.get instead of create custom promise.

Service

function loadPlaylists() {
     return $http.get('data/playlists.json')
     .then(function (data) {
         console.log('json data: ' + angular.toJson(data));
         return data;
     });
}

Resolve

resolve: {
    playlists: function(playlistsService){
         return playlistsService.loadPlaylists();
    }
}

edited Jul 18, 2015 at 19:41

answered Jul 18, 2015 at 18:41

Pankaj Parkar

136k23 gold badges241 silver badges307 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Derek Hannah Over a year ago

Since i am using resolve in .state, do i still need to resolve the $http data in my factory?

Pankaj Parkar Over a year ago

@DerekHannah yes..otherwise you could return the $http.post promise itself.. Let me update an answer

Collectives™ on Stack Overflow

angular-ui-route resolve with angularJS factory

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related