If within a loop not working as expected java

Question

I'm reading lines from a text file ("text.txt") and then storing them into a treemap, until the word apply appears.

However after performing this I don't have the last row "4 apply" I want in the treemap

text.txt
1 add
3 multiply
4 apply
6 add

Scanner input = new Scanner(file);
while(input.hasNextLine()){

    String line = input.nextLine();
    String[] divline = line.split(" ");

    TreeMap<Integer, String> Values = new TreeMap();

    if(!divline[1].equals("apply"))
    {
        Values.put(Integer.valueOf(divline[0]), divline[1]);    
    } 
    else
    {
        Values.put(Integer.valueOf(divline[0]), divline[1]);
        break;
    }

    System.out.println(Values);

}

You can put valores.put(Integer.valueOf(divline[0]), divline[1]); outside de ìf — Fran Montero
– Fran Montero, Commented Jul 31, 2015 at 10:16

Amit.rk3 · Accepted Answer · 2015-07-31 10:32:52Z

2

You are creating new map inside while loop every time. Put below code before while loop.

TreeMap<Integer, String> valores = new TreeMap();

Also printing of map content needs to be corrected. So your final code can be

Scanner input = new Scanner(file);
TreeMap<Integer, String> valores = new TreeMap();
     while(input.hasNextLine()){

        String line = input.nextLine();
        String[] divline = line.split(" ");           

        if(!divline[1].equals("apply")){
            valores.put(Integer.valueOf(divline[0]), divline[1]);   
        } else {
            valores.put(Integer.valueOf(divline[0]), divline[1]);
            break;
        }             

    }

for (Entry<Integer,String> entry: valores){
   System.out.println(entry.getKey() + "- "+entry.getValue());
}

edited Jul 31, 2015 at 10:32

answered Jul 31, 2015 at 10:18

Amit.rk3

2,4172 gold badges12 silver badges16 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Codebender · Accepted Answer · 2015-07-31 10:21:30Z

2

4 apply is getting added to valores map, but it's not getting printed because you are breaking out of the loop before the print statement.

Also, you may need to move the creation of valores map before while loop. And the printing after the loop.

    TreeMap<Integer, String> valores = new TreeMap();

    while(input.hasNextLine()){

    String line = input.nextLine();
    String[] divline = line.split(" ");

    if(!divline[1].equals("apply")){
        valores.put(Integer.valueOf(divline[0]), divline[1]);   
    } else {
        valores.put(Integer.valueOf(divline[0]), divline[1]);
        break;
    }
    }

    System.out.println(valores);

answered Jul 31, 2015 at 10:21

Codebender

14.5k7 gold badges51 silver badges87 bronze badges

Comments

Florian Schaetz · Accepted Answer · 2015-07-31 10:21:23Z

1

You are creating a new "valores" TreeMap for each line and then print that TreeMap that contains that one line. In the case of 'apply' you do the same, creating a new map, putting the value there - only by breaking, you skip the System.out.println part.

You need to put the declaration of the TreeMap before the while.

answered Jul 31, 2015 at 10:21

Florian Schaetz

10.7k5 gold badges35 silver badges61 bronze badges

Collectives™ on Stack Overflow

If within a loop not working as expected java

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related