PHP more efficient if else conditional logic

Question

I'm not very skilled when it comes to PHP but I've created this and it's probably not the best way to put it together but the only one that came to my mind right now.

What are we looking at?

It's the Apple Watch 'standing up in each hour' activity ring. This ring holds 12 image slices so called 'steps' because you have to stand up at least 12 times a day till you reach your goal (100% full circle) this means when you stand for 14 or 16 times a day the ring will loop further around 100% but the only difference between slide 2 and 14 is the background behind the circle will already be filled. Because I don't like to create 24 slices but only 12, I will rotate slide number 12 (full circle) X degree when the value gets over 12+ this will keep the amount of used images on the page low because we keep using slide number 12 most of the time only rotate it around for step 12 till 24.

Example: the blue middle ring

PHP wise everything is working so far but you can imagine how tall those if else list will become when I start the red 'move' or calories burned circle. This circle has 100 slices or better called steps. The green circle has 30 slices. That's why I was wondering if there is maybe a more lean way to make those if else steps. Maybe performance wise this can be done a lot better.

Thanks already..

have you used switch case statements ? if not have a look switch — anurupr
– anurupr, Commented Aug 16, 2015 at 11:04
If you don't mind, please copy/paste your code into the question rather than posting a screen capture of it. If you highlight the code block and click the {} editor toolbar button or ctl-k it will be indented 4 spaces with a preceding blank as a code block, which gets it syntax highlighting based on the php tag. It makes it much easier for answerers to assemble new code based on existing. — Michael Berkowski
– Michael Berkowski, Commented Aug 16, 2015 at 11:07
I did try to add the code but for some reason it all minified my if else and variables. into a single line. — Jack Ottermans
– Jack Ottermans, Commented Aug 16, 2015 at 14:05

jeroen · Accepted Answer · 2015-08-16 11:09:48Z

5

This looks like a simple math problem. Without looking at all the details and making it even shorter (there is probably no need for an if statement at all...), you can already see that:

if ($stand > 12) {
    $stanr = ($stand % 12) * 30;
    $stand = 12;
}

answered Aug 16, 2015 at 11:09

jeroen

91.8k22 gold badges117 silver badges132 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Jack Ottermans Over a year ago

Thanks, something like this was I looking for.. Easy and simple!

ankhzet · Accepted Answer · 2015-08-16 11:15:18Z

0

Erm...

$stanr = 0;
if ($stand <= 12) {
} elseif (($stand > 12) and ($stand < 24) {
    $stanr = ($stand - 12) * 30;
    $stand = 12;
else {
    $stand = 0;
}

answered Aug 16, 2015 at 11:15

ankhzet

2,5991 gold badge27 silver badges36 bronze badges

Collectives™ on Stack Overflow

PHP more efficient if else conditional logic

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related