Update sql query with PHP and variables

Question

When I run this page, its says You couldnt execute query. I think there is a syntax problem, but I cannot see the problem.

The variables look fine when I echo them. I added the column names as a code comment. All the columns are VARCHAR.

I don't believe it is a connection problem since I can perform SELECT AND DELETE operations from other php pages.

<?php 

$id = $_POST["id"];
$name = $_POST["name"];
$surname = $_POST["surname"];
$phone = $_POST["phone"];

/* Table in the DDBB(all are VARCHAR): CUST_ID  CUST_FORENAME   CUST_PHONE  CUST_SURNAME*/

$query = "UPDATE customers SET CUST_ID='$id',$CUST_FORENAME='$name',
            CUST_PHONE='$phone', CUST_SURNAME='$surname' WHERE CUST_ID=$id";

$result = mysqli_query ($connection,$query)
    or die ("You couldn’t execute query");

echo "<br /><br />User $id has been updated.";

?>
</div>
</body>
</html>

Do not use string concatenation in SQL queries. Use prepared statements. — Yeldar Kurmangaliyev
– Yeldar Kurmangaliyev, Commented Sep 17, 2015 at 11:49
Change your die("You couldn't...") function to die(mysqli_error($connection)), so that you will see the error description. — Yeldar Kurmangaliyev
– Yeldar Kurmangaliyev, Commented Sep 17, 2015 at 11:50
$CUST_FORENAME='$name' ? Shouldn't you delete that first character? :), as in CUST_FORENAME='$name' — Mihai Ovidiu Drăgoi
– Mihai Ovidiu Drăgoi, Commented Sep 17, 2015 at 11:51

Sarvagna Mehta · Accepted Answer · 2015-09-17 12:02:38Z

3

Change your query as follows and it will work

$query = "UPDATE customers SET CUST_ID='$id', CUST_FORENAME='$name',
                 CUST_PHONE='$phone', CUST_SURNAME='$surname' WHERE CUST_ID='$id'";

answered Sep 17, 2015 at 12:02

Sarvagna Mehta

3403 silver badges16 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Adrian Vazquez · Accepted Answer · 2015-09-17 12:02:16Z

1

Thanks guys, It was just a $ sign in one of the column and put back again quotes in the $id > '$id'.

$id = $_POST["id"];
$name = $_POST["name"];
$surname = $_POST["surname"];
$phone = $_POST["phone"];

/*CUST_ID   CUST_FORENAME   CUST_PHONE  CUST_SURNAME*/

$query = "UPDATE customers SET CUST_ID='$id',CUST_FORENAME='$name',
            CUST_PHONE='$phone', CUST_SURNAME='$surname' WHERE CUST_ID='$id'";

$result = mysqli_query ($connection,$query)
    or die(mysqli_error($connection));

echo "<br /><br />User $id has been updated.";

?>

answered Sep 17, 2015 at 12:02

Adrian Vazquez

3471 gold badge7 silver badges21 bronze badges

Collectives™ on Stack Overflow

Update sql query with PHP and variables

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related