Sql error while using "LIMIT".

Question

I'm getting error "Undeclared variable: $start" while using the SQL query below.

<?php
  if($Spage == ""){
     $Spage = "1";
  }
  $Sper_page = "5"; 
  $start = ($Spage-1)*$Sper_page;
  $sResults = $oCon->dbFetchSmarty("SELECT * FROM experts WHERE exp_process LIKE '%".$process."%' AND exp_machinaries like '%".$machineCat."%' AND exp_country = '". $country."' 'LIMIT $start, $Sper_page'");
?>

@jarlh - Depends on if the table is large or small - or if he wants ordered by default primary key. Order By is not necessary and lack of it is not really that odd depending on use case. — Gravy
– Gravy, Commented Oct 7, 2015 at 11:30

Gravy · Accepted Answer · 2015-10-07 11:26:58Z

1

You have messed your single quotes. Should be

$sResults = $oCon->dbFetchSmarty("SELECT * FROM experts WHERE exp_process LIKE '%".$process."%' AND exp_machinaries like '%".$machineCat."%' AND exp_country = '". $country."' LIMIT $start, $Sper_page");

And cleaning up the query a bit:

$sResults = $oCon->dbFetchSmarty("SELECT * FROM experts WHERE exp_process LIKE '%$process%' AND exp_machinaries like '%$machineCat%' AND exp_country = '$country' LIMIT $start, $Sper_page");

Next step to remove would be to use prepared statements and bind these parameters in

answered Oct 7, 2015 at 11:26

Gravy

12.5k26 gold badges129 silver badges194 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Hard Spocker · Accepted Answer · 2015-10-07 11:30:05Z

0

Try this: (another way in setting Limit and Offset)

<?php
  if($Spage == ""){
     $Spage = "1";
  }
  $Sper_page = "5"; 
  $start = ($Spage-1)*$Sper_page;
  $sResults = $oCon->dbFetchSmarty("SELECT * FROM experts WHERE exp_process LIKE '%".$process."%' AND exp_machinaries like '%".$machineCat."%' AND exp_country = '". $country."'LIMIT $per_page OFFSET $start'");
?>

And BTW you misplaced a single quote near LIMIT.

edited Oct 7, 2015 at 11:30

answered Oct 7, 2015 at 11:26

Hard Spocker

76511 silver badges33 bronze badges

3 Comments

RiggsFolly Over a year ago

Another member of the try this club Please explain WHY we should try this. Try this answers get put in the low quality queue and are often deleted

RiggsFolly Over a year ago

Better, but you only get a half corona

smc Over a year ago

@Hard Spocker I tried this code but getting error "Undeclared variable OFFSET"

RiggsFolly · Accepted Answer · 2015-10-07 11:35:06Z

0

You are making the creation of your query much too complicated and therefore missing some simple errors. Remember that when you use double quoutes " in PHP it will expand $variables into the string for you.

So a simpler and easier to read and therefore debug method would be this

$sql = "SELECT * FROM experts 
        WHERE exp_process LIKE '%$process%' 
          AND exp_machinaries like '%$machineCat%' 
          AND exp_country = '$country' 
        LIMIT $start, $Sper_page";

$sResults = $oCon->dbFetchSmarty($sql);

answered Oct 7, 2015 at 11:35

RiggsFolly

94.7k22 gold badges108 silver badges152 bronze badges

Comments

User1000547 · Accepted Answer · 2015-10-07 13:14:41Z

0

You left out a space between LIMIT and '. It must've been

$country."' '   LIMIT  .  ........

edited Oct 7, 2015 at 13:14

User1000547

4,3219 gold badges44 silver badges68 bronze badges

answered Oct 7, 2015 at 11:27

Peter Chaula

3,7812 gold badges36 silver badges37 bronze badges

Comments

Vipul Jethva · Accepted Answer · 2015-10-07 13:31:45Z

0

For best solution to check query is in phpmyadmin. You just echo query and copy/past query section into phpmyadmin. so it will give a proper guidance for your structure of query or any error for same.

answered Oct 7, 2015 at 13:31

Vipul Jethva

6751 gold badge9 silver badges28 bronze badges

Collectives™ on Stack Overflow

Sql error while using "LIMIT".

5 Answers 5

Comments

3 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

3 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related