Missing return in a function Swift

Question

I'm getting this error Missing return in a function expected to return "User" for this code:

var winner : User? {

    if player1TotalScore > player2TotalScore {
        return player1

    } else if player1TotalScore == player2TotalScore {
        return nil
    }
}

The most curious thing about this is that I do basically the same thing a few lines up:

var opponent : User! {
    if player1.isEqual(User.currentUser()) {
        return player2
    } else {
        return player1
    }
}

What am I doing wrong in the first bit of code?

Dave Wood · Accepted Answer · 2015-10-14 21:20:21Z

4

What happens if player1TotalScore is less than player2TotalScore. It falls through both if conditions and has no return value. You have to handle every case, and you're missing one here. That's why the else works, it handles both the == and the < cases.

answered Oct 14, 2015 at 21:20

Dave Wood

13.3k2 gold badges63 silver badges70 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Arsen · Accepted Answer · 2015-10-14 21:21:02Z

0

In case player1TotalScore < player2TotalScore your code will not return any value.

answered Oct 14, 2015 at 21:21

Arsen

11k3 gold badges39 silver badges47 bronze badges

Comments

Kevin Machado · Accepted Answer · 2015-10-14 21:30:20Z

0

You miss the last else statement

var winner : User? {

    if player1TotalScore > player2TotalScore {
        return player1

    } else if player1TotalScore == player2TotalScore {
        return nil
    } else {
        /// return player2 ?
    }
}

Without the last else winner returns nothing

Hope this helps you !

answered Oct 14, 2015 at 21:30

Kevin Machado

4,1973 gold badges31 silver badges55 bronze badges

Collectives™ on Stack Overflow

Missing return in a function Swift

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related