C++ Assigning Output of For Loop to a Variable

Question

I have a for loop that returns the user's input backwards. They enter a string, and the loop reverses it. Here's what it looks like:

string input;                          //what user enters
const char* cInput = input.c_str();    //input converted to const char*

for(int i = strlen(cInput) - 1; i >= 0; i--)
   cout << input[i];     //Outputs the string reversed

Instead of having cout << input[i], how can I set input[i] as the value of a new string? Like I want to have a string called string inputReversed and set it equal to input[i].

In other words, if input == hello, and input[i] == olleh, I want to set inputReversed equal to olleh.

Is this doable? Thanks!

Consider using std::string::size instead of converting to a const char* and using strlen. — Chris Drew
– Chris Drew, Commented Oct 20, 2015 at 21:49

Chris Drew · Accepted Answer · 2015-10-20 22:07:01Z

2

string inputReversed(input.rbegin(), input.rend());

answered Oct 20, 2015 at 22:07

Chris Drew

15.4k3 gold badges38 silver badges55 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

flogram_dev · Accepted Answer · 2015-10-20 22:08:09Z

2

Just declare the output string and append to it, either with += or the append member function:

string inputReversed;

for(int i = input.size() - 1; i >= 0; i--)
    inputReversed += input[i];         // this
//  inputReversed.append(input[i]);    // and this both do the same thing

Note that you don't need c_str and strlen, you can simply use the size or length member function.

You can also make the code more readable by using std::reverse:

string inputReversed = input;
std::reverse(inputReversed.begin(), inputReversed.end());

Or std::reverse_copy, since you're making a copy of the original string anyway:

string inputReversed;
std::reverse_copy(input.begin(), input.end(), std::back_inserter(inputReversed));

edited Oct 20, 2015 at 22:08

answered Oct 20, 2015 at 21:55

flogram_dev

43k11 gold badges109 silver badges161 bronze badges

1 Comment

Archie Gertsman Over a year ago

Thanks, I like this method. And I didn't use the reverse function because I wanted to make a palindrome detector as beginner practice :)

Dragonrage · Accepted Answer · 2015-10-20 21:54:29Z

1

If i understand what you are asking you want to have a variable to store the reversed string and output that? If so you can just do this

string input, InputReversed; 
                         //what user enters
const char* cInput = input.c_str();    //input converted to const char*

for(int i = strlen(cInput) - 1; i >= 0; i--){

    InputReversed += input[i];     

}
cout << InputReversed;  //Outputs the string reversed

answered Oct 20, 2015 at 21:54

Dragonrage

2251 gold badge7 silver badges20 bronze badges

Comments

Community · Accepted Answer · 2017-05-23 12:29:54Z

0

Going off of this thread may help you. How do I concatenate const/literal strings in C?

It seems like what you want is to create a new string which at the end of the loop will contain the backwards input.

string input;                          //what user enters
const char* cInput = input.c_str();    //input converted to const char*
char inputReversed[len(input)];

for(int i = strlen(cInput) - 1; i >= 0; i--)
   output = strcpy(output, input[i]);     //Outputs the string reversed

edited May 23, 2017 at 12:29

CommunityBot

11 silver badge

answered Oct 20, 2015 at 21:54

David Fackler

33 bronze badges

Collectives™ on Stack Overflow

C++ Assigning Output of For Loop to a Variable

4 Answers 4

Comments

1 Comment

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related