MySQL function giving wrong value

Question

I am creating a search engine whereby I require videos to be displayed according to the keywords input.

So for my codes, I have

$search_exploded = explode (" ", $search);
            foreach($search_exploded as $search_each){
                $x = 0; 
                $x++;

                if($x>=1){
                    $construct ="keywords LIKE '%$search_each%'";
                }

                else{
                    $construct ="OR keywords LIKE '%$search_each%'";

                }
                $x = 0;
            }

and

$query ="SELECT * FROM test WHERE $construct";

                    $runquery = mysql_query($query);

                    $foundnum = mysql_num_rows($runquery);

The problem lies in the $runquery as my the error i get from my browser states that the line $foundnum = mysql_num_rows($runquery); is returning a Boolean value instead of the supposed resource type value.

Can anyone help fix this? I'm stuck on this for quite some time now. Thankful for and appreciate any help!

You have a issue in your foreach.. You are resetting it each time you run through it, meaning it will always be 1. - also, your $construct is reset to the latest value each time it's run through the loop — Epodax
– Epodax, Commented Nov 10, 2015 at 8:27

gaurav rai · Accepted Answer · 2015-11-10 08:32:23Z

2

there is a problem in if condition and every time you set $x to 0 , then why you init it.

   $x = 0;
  foreach($search_exploded as $search_each){               
           if($x==0){ 
                $construct =" keywords LIKE '%$search_each%' ";
            }else{
                $construct .=" OR keywords LIKE '%$search_each%' ";
            }
            $x++;
        }

Try this .

edited Nov 10, 2015 at 8:32

answered Nov 10, 2015 at 8:28

gaurav rai

1033 silver badges11 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Mateo Barahona Over a year ago

$construct .="OR..." maybe no ?

gaurav rai Over a year ago

yes, $construct .=" OR keywords LIKE '%$search_each%' ";

Epodax Over a year ago

Just a small thing if you care, but there is no need for spaces in both ends of the $construct ends, it's enough with one in either end.

Kamehameha · Accepted Answer · 2015-11-10 08:58:06Z

2

You have a couple of logical errors inside your foreach loop pertaining to the $x variable.

Here is a simple way to achieve what you are trying to do (without using some kind of flags like $x)-

$search_exploded = explode (" ", $search);

// An array for the `LIKE` conditions
$construct_list = [];

// Adding the conditions in the array
foreach($search_exploded as $search_each){
    $construct_list[] = "keywords LIKE '%$search_each%'";
}

// Joining them using OR
$construct = implode(" OR ", $construct_list);

// Supposing there are no keywords, the
// WHERE should not exist. So make a separate var for that - 
$where_clause = "";
if(trim($construct) != ""){
    $where_clause = "WHERE $construct";
}

// Perform your query
$query ="SELECT * FROM test $where_clause";

edited Nov 10, 2015 at 8:58

answered Nov 10, 2015 at 8:31

Kamehameha

5,4781 gold badge25 silver badges31 bronze badges

1 Comment

Jun Jie Over a year ago

Great, this worked out for me! Thanks for your help. :)

Sanjay Kumar N S · Accepted Answer · 2015-11-10 08:32:57Z

0

Try this:

            $search_exploded = explode (" ", $search);
            $construct = '1';
            if (!empty($search_exploded)) {
                $construct = '';
                foreach($search_exploded as $search_each){
                    $construct .= $construct == '' ? " keywords LIKE '%$search_each%'" : " OR keywords LIKE '%$search_each%'";
                }
            }
            $query ="SELECT * FROM test WHERE $construct";

            $runquery = mysql_query($query);
            if ($runquery) {
                $foundnum = mysql_num_rows($runquery);
            }

answered Nov 10, 2015 at 8:32

Sanjay Kumar N S

4,7595 gold badges25 silver badges41 bronze badges

Comments

Kickstart · Accepted Answer · 2015-11-10 09:13:38Z

0

You seem to try to omit the OR for the 2nd and subsequent runs around the loop, but keep it for the first. should be the other way round,.

But I would probably avoid using the loop, and just use implode. Something like this (although would need to escape the values before using them in the query).

$search_exploded = explode (" ", $search);

if (count($search_exploded) > 0)
{

    $construct = implode("%' OR keywords LIKE '%", $search_exploded);

    $query ="SELECT * FROM test WHERE keywords LIKE '%".$construct."%'";

    $runquery = mysql_query($query);

    $foundnum = mysql_num_rows($runquery);

}

answered Nov 10, 2015 at 9:13

Kickstart

21.5k2 gold badges26 silver badges33 bronze badges

Collectives™ on Stack Overflow

MySQL function giving wrong value

4 Answers 4

3 Comments

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

3 Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related