Cannot compare user-defined objects for sorting (Java 8)

Question

I have following classes-

public class Pair
{
    public double value;
    int id;

    Pair(){
        value=0;
        id=0;
    }
    Pair(double value, int id){
        this.value=value;
        this.id=id;
    }
}

PairComparator class to be used for implementing Comparator class

public class PairComparator implements Comparator<Pair>{
    @Override
    public int compare(Pair p1, Pair p2){
        return (int)(p2.value-p1.value);
    }
}

I'm trying to sort a Pair collection as follows-

List<Pair> list= new ArrayList<Pair>();
list.add(new Pair(5.2, 4));
list.add(new Pair(3.4, 5));
list.add(new Pair(10.3, 3));

Collections.sort(list, new PairComparator());

However I'm getting following error-

`Exception in thread "main" java.lang.IllegalArgumentException: Comparison method violates its general contract!

Exception in thread "main" java.lang.IllegalArgumentException: Comparison method violates its general contract!
at java.util.TimSort.mergeHi(TimSort.java:895)
at java.util.TimSort.mergeAt(TimSort.java:512)
at java.util.TimSort.mergeCollapse(TimSort.java:435)
at java.util.TimSort.sort(TimSort.java:241)
at java.util.Arrays.sort(Arrays.java:1512)
at java.util.ArrayList.sort(ArrayList.java:1454)
at java.util.Collections.sort(Collections.java:175)
at com.research.priyanshuid.recommendation_system.MatrixRecalculation.main(MatrixRecalculation.java:59)

@MadushanPerera I don't exactly have the list items as inserted in the above code, do you think that the code might be producing error due to problem in the data? — Priyansu Singh
– Priyansu Singh, Commented Nov 23, 2015 at 5:52
No if you did not provide the list items it should compile and run fine but without any out-put. — Madushan Perera
– Madushan Perera, Commented Nov 23, 2015 at 5:56
I mean I have data in the list but it is not inserted in the way as done in the above list, so is it possible that the comparator class gives this particular error because of the incompatibility of datatype? — Priyansu Singh
– Priyansu Singh, Commented Nov 23, 2015 at 5:59
Incompatibility of datatype right away gives you a compile error since you cant pass String value as the first parameter of your Pair class constructor . — Madushan Perera
– Madushan Perera, Commented Nov 23, 2015 at 6:15
"is not inserted in the way as done in the above list" so which way you have inserted ??? — Madushan Perera
– Madushan Perera, Commented Nov 23, 2015 at 6:16

Community · Accepted Answer · 2017-05-23 11:44:30Z

5

You usually get this error when the comparator violates the transitivity - check this answer.

When using double in a Comparator, you should avoid using the substraction logic. Since you're converting the result into an int, it would be rounded and thus would break transitivity while comparing values like 5.1, 5.2 etc. Check this answer for details.

You're better off using a comparator logic as so:

public int compare(Pair p1, Pair p2) {
   if (p1.value < p2.value) return -1;
   if (p1.value > p2.value) return 1;
   return 0;
}

As mentioned by sarilks - if you're expecting NaN values better use in-built compare function -

public int compare(Pair p1, Pair p2){
    return Double.compare(p1.value, p2.value);
}

edited May 23, 2017 at 11:44

CommunityBot

11 silver badge

answered Nov 23, 2015 at 5:58

Vinay Rao

1,2749 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Saril Sudhakaran · Accepted Answer · 2015-11-23 06:06:21Z

4

Since you are comparing Double values , its safer to use Double.compare

 public int compare(Pair p1, Pair p2){
    return Double.compare(p1.value, p2.value);
}

answered Nov 23, 2015 at 6:06

Saril Sudhakaran

1,1299 silver badges18 bronze badges

Comments

Tagir Valeev · Accepted Answer · 2015-11-23 06:35:20Z

4

In Java-8 you can do this safely and without additional PairComparator class:

Collections.sort(list, Comparator.comparingDouble(p -> p.value));

answered Nov 23, 2015 at 6:35

Tagir Valeev

101k19 gold badges233 silver badges346 bronze badges

Collectives™ on Stack Overflow

Cannot compare user-defined objects for sorting (Java 8)

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related