PHP - If a word contains a certain string replace it

Question

I have an array with bad strings that i want to replace in certain words, currently i wrote this code to manage this but its not working as it should:

public function _clean_filename($fn)
{
    if($fn === '')
        return;

    foreach((array)$_filename_bad_chars as $bad)
    {
        if(strpos($fn, $bad))
        {
            str_replace($bad, '', $fn);
        }
    }
    return $fn;
}

Simptom: When i input a word with bad strings in it the function returns nothing.

How should i rewrite this code to make it functional?

So where is $_filename_bad_chars defined. Not in the scope of this function thats for sure — RiggsFolly
– RiggsFolly, Commented Feb 1, 2016 at 23:06
Well then try $this->_filename_bad_chars and loose the (array) casting unless of course its not an array?? — RiggsFolly
– RiggsFolly, Commented Feb 1, 2016 at 23:08
str_replace($bad, '', $fn); returns a string, you are dumping it into the ether, see @Forseti answer — RiggsFolly
– RiggsFolly, Commented Feb 1, 2016 at 23:12

RiggsFolly · Accepted Answer · 2016-02-01 23:11:56Z

4

Seems that:

$_filename_bad_chars should be $this->_filename_bad_chars
str_replace($bad, '', $fn); should be $fn = str_replace($bad, '', $fn);

edited Feb 1, 2016 at 23:11

RiggsFolly

94.7k22 gold badges108 silver badges152 bronze badges

answered Feb 1, 2016 at 23:10

Forseti

2,9856 gold badges26 silver badges35 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Andrei Vlad Over a year ago

Lol, i feel like a total noob right now! Thank you very much guys!

Steve Over a year ago

the loop is also surplus, as str_replace accepts arrays

Steve · Accepted Answer · 2016-02-01 23:24:41Z

2

you can simplify the whole method:

public function _clean_filename($fn)
{        
    return str_replace($this->_file_bad_chars, '', $fn);
}

str_replace accepts arrays for all parameters, and given an empty string for subject will return an empty string

also, your use of a leading underscore for a public method is odd!

answered Feb 1, 2016 at 23:24

Steve

20.5k5 gold badges47 silver badges71 bronze badges

Collectives™ on Stack Overflow

PHP - If a word contains a certain string replace it

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related