python - Issue using classes imported from a module

Question

My assignment is to make a game, were supposed to have multiple modules to avoid clutter in one script. I'm having an issue with import a variable from one of the modules. So far I have a settings one, and a main one. The settings is pretty simple and goes:

class Settings():
def __init__(self):
    self.screen_width = 1920
    self.screen_height = 1080
    self.bg_color = (230, 230, 230)

Pretty simple, yet when I try to reference these variables it says "Unresolved attribute reference 'screen_width' for class 'Settings'

main goes as this:

import sys, pygame
from game_settings import Settings

def run_game():
    #Initialize the game and create the window
    pygame.init()
    screen = pygame.display.set_mode((Settings.screen_width,Settings.screen_height), pygame.FULLSCREEN)
    pygame.display.set_caption("Alien Invasion")

while True:

    #Listening for events
    for event in pygame.event.get():
        if event.type == pygame.QUIT:
             sys.exit()
    screen.fill(Settings.bg_color)
    pygame.display.flip()

run_game()

I thought maybe this would be a PyCharm issue, but found that it does the same thing in IDLE so what would be the correct way to import the variables?

Thanks for taking the time to read this!

I am definitely no expert, but arent bg_color , screen_width and scree_height part of the instances rather than the class itself? In other words, I dont think you can just access Settings.bg_color, I think you need to make a Settings object like s = Settings() and then you can do s.bg_color. — Andrés AG
– Andrés AG, Commented Feb 14, 2016 at 23:02
Btw, have a look at this article if you would like to learn more about this issue you are having docs.python.org/3/tutorial/classes.html — Andrés AG
– Andrés AG, Commented Feb 14, 2016 at 23:10
@AndrésAG Thanks, such a simple problem I was missing though. I knew mostly how to get it all except that I needed to create an instance. — Evan Theis
– Evan Theis, Commented Feb 14, 2016 at 23:20

Blckknght · Accepted Answer · 2016-02-14 23:04:01Z

2

You need to create an instance of your Settings class, since the attributes you set up in its __init__ method are instance attributes.

Try something like this:

def run_game():
    my_settings = Settings() # create Settings instance
    pygame.init()
    screen = pygame.display.set_mode((my_settings.screen_width, # lookup attributes on it
                                      my_settings.screen_height),
                                     pygame.FULLSCREEN)
    # ...

answered Feb 14, 2016 at 23:04

Blckknght

106k11 gold badges135 silver badges188 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Nick · Accepted Answer · 2016-02-14 23:09:47Z

0

You need to create an instance of the Settings object: s = Settings()

Usage: s.bg_color, etc.

OR

Alter your Settings class like so and the properties are accessible statically:

class Settings():
    screen_width = 1920
    screen_height = 1080
    bg_color = (230, 230, 230)

edited Feb 14, 2016 at 23:09

answered Feb 14, 2016 at 23:03

Nick

7,5012 gold badges25 silver badges46 bronze badges

Comments

pp_ · Accepted Answer · 2016-02-15 02:10:08Z

0

Both files have to be in the same folder and you have to create an instance of your Settings class. Then you can access the properties of your instance.

main.py:

from game_settings import Settings
s = Settings()
print(s.bg_color)

game_settings.py:

class Settings():
    def __init__(self):
        self.screen_width = 1920
        self.screen_height = 1080
        self.bg_color = (230, 230, 230)

When you run main.py, the output will be:

(230, 230, 230)

edited Feb 15, 2016 at 2:10

answered Feb 14, 2016 at 23:10

pp_

3,5134 gold badges21 silver badges27 bronze badges

Collectives™ on Stack Overflow

python - Issue using classes imported from a module

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related