How to using class with static method in C#?

Question

I want using class ToDataTable() to convert List to DataTable. Problem is: class ToDataTable() using static method and it make error. I know this error but I don't know how to resolve it.

The error code is: Extension method must be defined in a non-generic static class

My code using is:

var proxyInfos = proxyL
            .Where(l => l.Contains(" US "))
            .Select(l => l.Split(' '))
            .Select(tokens => new
            {
                IP = tokens[0],
                Port = tokens[1]
            })
            .ToList();
        dtProxy = ToDataTable(proxyInfos);

And class to convert List to DataTable:

public static DataTable ToDataTable<T>(this IList<T> data)
{
    PropertyDescriptorCollection properties =
        TypeDescriptor.GetProperties(typeof(T));
    DataTable table = new DataTable();
    foreach (PropertyDescriptor prop in properties)
        table.Columns.Add(prop.Name, Nullable.GetUnderlyingType(prop.PropertyType) ?? prop.PropertyType);
    foreach (T item in data)
    {
        DataRow row = table.NewRow();
        foreach (PropertyDescriptor prop in properties)
            row[prop.Name] = prop.GetValue(item) ?? DBNull.Value;
        table.Rows.Add(row);
    }
    return table;
}

I was research on the internet. Like, change my class to static. But I change to static and error continues to appear: Static class 'MyClass.MainForm' cannot derive from type 'System.Windows.Forms.Form'. Static classes must derive from object..

My code like this:

public static class MainForm : System.Windows.Forms.Form
{
}

Possible duplicate of Static classes must derive from object (C#) — Alfie Goodacre
– Alfie Goodacre, Commented Feb 18, 2016 at 10:29
I think you should move this method, ToDataTable into static class and make it as Extension method. So you can simply use it as, dtProxy = proxyInfos.ToDataTable(); — Hiren Visavadiya
– Hiren Visavadiya, Commented Feb 18, 2016 at 10:29

Grundy · Accepted Answer · 2016-02-18 10:42:27Z

3

Just remove this

public static DataTable ToDataTable<T>(IList<T> data)

and use as simple static method

Or move this function to separated static class

like

public static class UnilityExtensions
{
    public static DataTable ToDataTable<T>(this IList<T> data)
    { ... }
}

edited Feb 18, 2016 at 10:42

answered Feb 18, 2016 at 10:28

Grundy

13.4k3 gold badges39 silver badges57 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Dai Over a year ago

Spot-on, with a minor minor thing: CLR naming conventions hold that classes holding extension methods should be named with the suffix "Extensions", in this case "ListExtensions".

lan Over a year ago

I tried add to static class but not work. But when I remove this, that run perfectly. Thanks

Felipe Oriani · Accepted Answer · 2016-02-18 10:28:21Z

2

No, you cannot define a form as a static class because it have to be instanced. TO have an extension method you need a static class, but not necessarily you need to chnage your form class. Create a new static class and put your extensions methods there. See the MSDN docs here.

Extension methods are defined as static methods but are called by using instance method syntax.

public static class MyExtensions
{
    public static DataTable ToDataTable<T>(this IEnumerable<T> str)
    {
        PropertyDescriptorCollection properties = TypeDescriptor.GetProperties(typeof(T));
        DataTable table = new DataTable();

        foreach (PropertyDescriptor prop in properties)
            table.Columns.Add(prop.Name, Nullable.GetUnderlyingType(prop.PropertyType) ?? prop.PropertyType);

        foreach (T item in data)
        {
            DataRow row = table.NewRow();
            foreach (PropertyDescriptor prop in properties)
                row[prop.Name] = prop.GetValue(item) ?? DBNull.Value;
            table.Rows.Add(row);
        }

        return table;
    }
}

Another suggestion, change you IList<T> to IEnumerable<T> because you can keep an extension method for more collections because the IEnumerable is more abstract than IList.

answered Feb 18, 2016 at 10:28

Felipe Oriani

38.7k20 gold badges141 silver badges203 bronze badges

1 Comment

lan Over a year ago

Thanks your tips - IEnumerable<T>

Carbine · Accepted Answer · 2016-02-18 10:28:23Z

2

You cant do public static class MainForm : System.Windows.Forms.Form because you cant derive static class from another class.

Although you can do this:

using SomeNamespace
{
    public static class FormExtension
    {
        public static DataTable ToDataTable<T>(this IList<T> data)
        {
           ...
        }
    }
}

Make sure the place where you need to access the extension includes the namespace containing the Extension method. So any IList<T> will have access to this ToDataTable<T> method.

answered Feb 18, 2016 at 10:28

Carbine

7,9134 gold badges34 silver badges56 bronze badges

Comments

Hiren Visavadiya · Accepted Answer · 2016-02-18 10:33:25Z

0

Move your method into static class, and make it extension method as per below given,

 public static class Extension
{
    public static DataTable ToDataTable<T>(this IList<T> data)
    {
        PropertyDescriptorCollection properties =
            TypeDescriptor.GetProperties(typeof(T));
        DataTable table = new DataTable();
        foreach (PropertyDescriptor prop in properties)
            table.Columns.Add(prop.Name, Nullable.GetUnderlyingType(prop.PropertyType) ?? prop.PropertyType);
        foreach (T item in data)
        {
            DataRow row = table.NewRow();
            foreach (PropertyDescriptor prop in properties)
                row[prop.Name] = prop.GetValue(item) ?? DBNull.Value;
            table.Rows.Add(row);
        }
        return table;
    }
}

and replace your line,

dtProxy = ToDataTable(proxyInfos);

with,

dtProxy = proxyInfos.ToDataTable();

answered Feb 18, 2016 at 10:33

Hiren Visavadiya

4951 gold badge3 silver badges16 bronze badges

1 Comment

lan Over a year ago

Thank for your answer. I was try your code. It's work.

Collectives™ on Stack Overflow

How to using class with static method in C#?

4 Answers 4

2 Comments

1 Comment

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

1 Comment

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related