Code not creating directories

Question

I'm trying to write a folder to the desktop. So far, I've gotten to this point. I initialize the method like this:

 public class Initialize 
        {
            public static void Main () 
            {
                Folder.CreateFolder();
            }
        }

And it takes the code from here:

public class Folder
    {
        public static void CreateFolder()
        {
            string path = Environment.GetFolderPath(Environment.SpecialFolder.Desktop); //Gets desktop folder
            if(System.IO.Directory.Exists(path))
            {
                System.IO.Directory.CreateDirectory(path); 
            }
        }
    }

I'm thinking part of my problem is in the CreateDirectory call, but I'm not sure. All I know is only a terminal pops up, and no folder is created. Can anyone see the error? Let me know, thanks in advance!

This code won't create a directory anyway, as when it's fixed as indicated by @Ashkan, it'll try to create the Desktop directory, which already exists... — CodeCaster
– CodeCaster, Commented Mar 1, 2016 at 19:49
If you wish to create a directory on your desktop, then just combine the Desktop directory with your intended directory name (using Path.Combine method: msdn.microsoft.com/en-us/library/fyy7a5kt%28v=vs.110%29.aspx). But you should only create that directory if it doesn't already exist, rather than if it does. And don't try to create the Desktop directory. — ManoDestra
– ManoDestra, Commented Mar 1, 2016 at 20:14

Ashkan Mobayen Khiabani · Accepted Answer · 2016-03-01 20:02:15Z

2

You must Try to create folder if it does not exist and also use Environment.SpecialFolder.DesktopDirectory instead of Environment.SpecialFolder.Desktop

Add ! to your comparison

public class Folder
    {
        public static void CreateFolder()
        {
            string path = Environment.GetFolderPath(Environment.SpecialFolder.DesktopDirectory); //Gets desktop folder
            if(!System.IO.Directory.Exists(path))
            {
                System.IO.Directory.CreateDirectory(path); 
            }
        }
    }

edited Mar 1, 2016 at 20:02

answered Mar 1, 2016 at 19:44

Ashkan Mobayen Khiabani

34.4k35 gold badges111 silver badges187 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Michael Mairegger Over a year ago

You could just call Directory.CreateDirectory, because this code will internally check if the directory is existing or not.

Scott Chamberlain · Accepted Answer · 2016-03-01 19:49:14Z

1

Use Enviorment.SpecialFolder.DesktopDirectory instead, the Enviorment.SpecialFolder.Desktop enumeration is a virtual folder.

answered Mar 1, 2016 at 19:49

Scott Chamberlain

128k37 gold badges299 silver badges448 bronze badges

Collectives™ on Stack Overflow

Code not creating directories

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related