Use PHP in Query

Question

I have a very noobish question right here. How can I use PHP in my PHP SQL query?

My query is

mysqli_query($GLOBALS["___mysqli_ston"], "SELECT * FROM shop WHERE categorie='4' AND actief='1' ORDER BY prijs + 0 ASC");

and what I'm trying to have is this

mysqli_query($GLOBALS["___mysqli_ston"], "SELECT * FROM shop WHERE categorie='4' AND ". if(htmlentities($gegevens['rang']) == '1') { echo ""; } else { echo "actief='1'";} . " ORDER BY prijs + 0 ASC");

How can I get this to work?

chugadie · Accepted Answer · 2016-03-05 00:39:30Z

1

For everyone's sanity, please do not use ternary conditions inside SQL string concatenation.

$andActeif = "";
if (intval($gegevens['rang']) == 1) {
    $andActive = " AND acteif = '1' ";
}
mysqli_query($GLOBALS["___mysqli_ston"], "
   SELECT * 
   FROM shop
   WHERE categorie='4'
   $andActeif
   ORDER BY prijs + 0 ASC");

Your future self will thank you.

answered Mar 5, 2016 at 0:39

chugadie

2,9031 gold badge27 silver badges33 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Community · Accepted Answer · 2017-05-23 11:45:02Z

0

You need to use the ?: conditional (AKA ternary) expression.

mysqli_query($GLOBALS["___mysqli_ston"], "SELECT * FROM shop WHERE categorie='4' ". ($gegevens['rang'] == '1' ? "" : "AND actief='1'") . " ORDER BY prijs + 0 ASC");

And the AND should be part of the string that's added by the conditional code. Otherwise, when $gegevens['rang'] is not 1, you'll have AND with no condition after it.

For a more general approach to building the WHERE clause dynamically, see

Search Form with One or More (Multiple) Parameters

edited May 23, 2017 at 11:45

CommunityBot

11 silver badge

answered Mar 5, 2016 at 0:17

Barmar

789k57 gold badges555 silver badges669 bronze badges

3 Comments

Carl Over a year ago

Hello Barmar, when I'm working with your code it give me an error: "You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'ORDER BY prijs + 0 ASC' at line 1"

Matt Over a year ago

The AND should be in the conditional ;)

Matt Over a year ago

mysqli_query($GLOBALS["___mysqli_ston"], "SELECT * FROM shop WHERE categorie='4' ". ($gegevens['rang'] == '1' ? "" : " AND actief='1'") . " ORDER BY prijs + 0 ASC");

Collectives™ on Stack Overflow

Use PHP in Query

2 Answers 2

Comments

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related