async method within non-async loop

Question

I am using a loop to place images in my canvas, there is a method that needs to check if each looped images have an attribute that is stored in a JSON file.

the checkImage method works fine outside the loop, but when I place it in the loop it gives this error:

"Access denied, file is used by another process"

Since the method gets called for every image created by the loop I guess that I need to close the JSON file after its serialized or something, but how?

The loop:

 while (i < blauw)
                {
                    checkImage(i); //checks if it has the attribute or not
                    ImageBrush brush = new ImageBrush();
                    Button Btn = new Button();
                    Uri uri = new Uri("ms-appx://Blijfie/images/" + selected + "/" + blauwpics[i]);
                    BitmapImage imgSource = new BitmapImage(uri);
                    brush.ImageSource = imgSource;
                    Btn.Background = brush;
                    Btn.Width = 200;
                    Btn.Height = 200;

                    if (i >= 5 && i < 10)
                    {
                        Canvas.SetTop(Btn, marginTop);
                        Canvas.SetLeft(Btn, marginLeft2);
                        marginLeft2 = marginLeft2 + 250;
                    }
                    else if (i < 6)
                    {
                        Canvas.SetLeft(Btn, marginLeft);
                        marginLeft = marginLeft + 250;

                    }
                    else if (i >= 10)
                    {
                        Canvas.SetTop(Btn, marginTop2);
                        Canvas.SetLeft(Btn, marginLeft3);
                        marginLeft3 = marginLeft3 + 250;
                    }
                    main.Children.Add(Btn);
                    i++;

                }

CheckImage method:

 private async void checkImage(int id) {
                    var foldertest = ApplicationData.Current.TemporaryFolder;
                    var files = await foldertest.GetFilesAsync();
                    var desiredFile = files.FirstOrDefault(x => x.Name == "Dierendb.json");
                    var textContent = await FileIO.ReadTextAsync(desiredFile);

                    var result = JsonConvert.DeserializeObject<List<Dier>>(textContent);

                    id++;

                    if (result[id].PathDier.Equals(""))
                    {
                        //do this
                    }
                    else
                    {
                        //do that
                    }


                    string dierenlijst = JsonConvert.SerializeObject(result, Formatting.Indented);
                    await Windows.Storage.FileIO.WriteTextAsync(desiredFile, dierenlijst, Windows.Storage.Streams.UnicodeEncoding.Utf8);

    }

Added the loop, didn't think it was necessary. Why is it a bad idea? There is probably a better way to do this, but can't think of 1. — Yoshi
– Yoshi, Commented Mar 25, 2016 at 14:37
Because void can't be awaited. Note that in the loop you're not awaiting the method. If multiple calls to the method are simultaneously trying to write to the same file, then the file system is going to refuse that. — David
– David, Commented Mar 25, 2016 at 14:40
Stephen Cleary explains it well. msdn.microsoft.com/en-us/magazine/jj991977.aspx His blog is very good about all things async blog.stephencleary.com/2012/02/async-and-await.html — HebeleHododo
– HebeleHododo, Commented Mar 25, 2016 at 14:40

Archana · Accepted Answer · 2016-03-25 14:45:54Z

4

Return the Task instead of void. And await for it complete in loop like this.

  while (i < blauw)
                {
                    var bool= await checkImage(i); //checks if it has the attribute or not
                    ImageBrush brush = new ImageBrush();
                    Button Btn = new Button();
                    Uri uri = new Uri("ms-appx://Blijfie/images/" + selected + "/" + blauwpics[i]);
                    BitmapImage imgSource = new BitmapImage(uri);
                    brush.ImageSource = imgSource;
                    Btn.Background = brush;
                    Btn.Width = 200;
                    Btn.Height = 200;

                    if (i >= 5 && i < 10)
                    {
                        Canvas.SetTop(Btn, marginTop);
                        Canvas.SetLeft(Btn, marginLeft2);
                        marginLeft2 = marginLeft2 + 250;
                    }
                    else if (i < 6)
                    {
                        Canvas.SetLeft(Btn, marginLeft);
                        marginLeft = marginLeft + 250;

                    }
                    else if (i >= 10)
                    {
                        Canvas.SetTop(Btn, marginTop2);
                        Canvas.SetLeft(Btn, marginLeft3);
                        marginLeft3 = marginLeft3 + 250;
                    }
                    main.Children.Add(Btn);
                    i++;

               }

Private Task<bool> CheckImage(int i)
{
Yourcode
Return true;
}

edited Mar 25, 2016 at 14:45

answered Mar 25, 2016 at 14:40

Archana

3,2211 gold badge17 silver badges21 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Yoshi Over a year ago

seems to work for now, will test it further. Cheers!

Community · Accepted Answer · 2017-05-23 11:53:02Z

1

In this answer you can find good explanation difference between returning void and Task. In you case you should change return type to Task and await it in your loop

edited May 23, 2017 at 11:53

CommunityBot

11 silver badge

answered Mar 25, 2016 at 14:46

Arkhangelskiy Evgeniy

6315 silver badges13 bronze badges

Collectives™ on Stack Overflow

async method within non-async loop

2 Answers 2

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related