Error using anchor tag in javascript

Question

  var titleLink=document.createElement("a");
  titleLink.setAttribute("href",'answers[3][i]');
  titleLink.innerHTML=answers[1][i];  

  newDiv.appendChild(titleLink);

When I click on the link when created through js, it shows page not found. But the same link when I add it explicitly using <a> tag in html opens correctly. What could be the problem??

Link to the entire code is here: http://codepen.io/jpninanjohn/pen/GZrzoG

titleLink.setAttribute("href",answers[3][i]);, remove the quotes of answers.. — ojovirtual
– ojovirtual, Commented Apr 7, 2016 at 14:52
That string is unlikely to be the href, try removing the quotes answers[3][i]. Also try using the console to debug: console.log(titleLink.href). — David Thomas
– David Thomas, Commented Apr 7, 2016 at 14:52
As said, you are setting the href attribute with a string instead of the array position codepen.io/anon/pen/yOpggx — Yuri
– Yuri, Commented Apr 7, 2016 at 14:53

arshovon · Accepted Answer · 2016-04-07 15:01:36Z

1

I assume this is an exercise of FreeCodeCamp. As a FreeCodeCamper, it is nice to see another camper asking question in stackoverflow.

Anyway, you are almost near to the solution! Just make this tweak and you are good to go!

titleLink.setAttribute("target","_blank");
titleLink.setAttribute("href",answers[3][i]);
titleLink.innerHTML=answers[1][i];

It was a typo that you added single quotation over answers[3][i]. Optionally, I added an attribute to open the link in a new tab.

Hope it helps!

answered Apr 7, 2016 at 15:01

arshovon

13.7k9 gold badges54 silver badges72 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Brett Green · Accepted Answer · 2016-04-07 14:54:56Z

1

Remove the single quotes around answer:

  var titleLink=document.createElement("a");
  titleLink.setAttribute("href",answers[3][i]);
  titleLink.innerHTML=answers[1][i];  

  newDiv.appendChild(titleLink);

answered Apr 7, 2016 at 14:54

Brett Green

3,7761 gold badge24 silver badges32 bronze badges

Comments

Denys Oliinyk · Accepted Answer · 2016-04-07 14:53:50Z

0

You have error in you code, you pass 'answers[3][i]' as a string. Try without brackets )

answered Apr 7, 2016 at 14:53

Denys Oliinyk

1,0842 gold badges13 silver badges28 bronze badges

Collectives™ on Stack Overflow

Error using anchor tag in javascript

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related