Instance of FXML controller in JavaFX returns null

Question

I want to create a reference for the FXML Controller by this line in Class Main

Controller controller = (Controller) loader.getController();

to have access to a Controller methode from the Class GrblListener.

Main.controller.updateCurrentPosition(input);

But I always get the error

Exception in thread "EventThread COM5" java.lang.NullPointerException

What's wrong?

Class Main:

public class Main extends Application {

    public static Stage stage;
    public static Controller controller;

    @Override
    public void start(Stage stage) throws Exception {

        FXMLLoader loader = new FXMLLoader(getClass().getResource("Scene.fxml"));
        Parent root = (Parent) loader.load();
        Controller controller = (Controller) loader.getController();

        Scene scene = new Scene(root);
        scene.getStylesheets().add(getClass().getResource("css/default.css").toExternalForm());

        stage.setTitle("...");
        stage.setScene(scene);
        stage.show();

        this.stage = stage;
    }

    public static void main(String[] args) {
        launch(args);
    }
}

Class GrblListener:

class GrblListener implements SerialPortEventListener {

    @Override
    public void serialEvent(SerialPortEvent event) {

        if(event.isRXCHAR() && event.getEventValue() > 0){

            try {
                String input = GrblSender.serialPort.readString();
                System.out.println(input.trim());

                Main.controller.updateCurrentPosition(input);
            }
                catch (SerialPortException ex) {
                System.out.println(ex);
            }
        }
    }
}

How to you connect the controller? Manually? Or in FXML? Haven't you forgot fx:controller="Controller" in FXML? — DVarga
– DVarga, Commented Apr 7, 2016 at 16:32
I created the FXML with SceenBuilder, so I connect with fx:controller="package.Controller". — Luke
– Luke, Commented Apr 7, 2016 at 16:44
For now I avoid the problem by creating a public variable in the Class GrblListener which I then check with a timer every second in Class Controller to trigger the action ... Not the best solution ... — Luke
– Luke, Commented Apr 7, 2016 at 16:48

James_D · Accepted Answer · 2016-04-07 16:44:02Z

2

You are declaring a local variable in start(), and initializing it:

Controller controller = (Controller) loader.getController();

instead of initializing the static variable you declared:

public static Controller controller ;

public void start(Stage stage) {

    controller = (Controller) loader.getController();

    // ...
}

answered Apr 7, 2016 at 16:44

James_D

211k16 gold badges312 silver badges345 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Instance of FXML controller in JavaFX returns null

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related