Internal JS Angular Controller not getting called

Question

I've written a controller in the script tag in my HTML. When I run the code, the code is executed till the dependency injection, but the callback function is not executed.

I'm not able to figure out what is wrong with this when a similar code runs successfully on other apps I've worked on.

Also, if I call the callback function explicitly then the dependencies injected are not identified.

<script type="text/javascript">
    angular.module('DesignPortal.layout', [])
        .controller('NgLayoutController', NgLayoutController);

    NgLayoutController.$inject = ['$scope'];

    function NgLayoutController($scope) {
        var loggedUserId = dpConfig.userInfo.id;
    }
</script>

The scope injected above is not identified if the function is called explicitly.

Abhinav · Accepted Answer · 2016-04-11 08:41:54Z

1

It's Working on my plunk.

<script type="text/javascript">
    angular.module('DesignPortal.layout', [])
        .controller('NgLayoutController', NgLayoutController);

    NgLayoutController.$inject = ['$scope'];

    function NgLayoutController($scope) {
      alert("Its working!");
        var loggedUserId = dpConfig.userInfo.id;
    }
</script>

This happens due to a number of reasons such as removing a script for index.html for a module but leaving in the module dependency or even misspelling a module dependency.

The first thing you need to do is make sure all modules dependencies are spelled right, then make sure all files are loaded.

edited Apr 11, 2016 at 8:41

answered Apr 11, 2016 at 8:23

Abhinav

2462 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Ashish Dwivedi Over a year ago

Yes, It does. The thing which I was not doing was that I wasn't including the controller on the HTML with the ng-controller directive. I had the understanding that inclusion in HTML is not required. But, apparently I was wrong.

Miroslav Jonas · Accepted Answer · 2016-04-11 07:44:11Z

1

Do you have some error in the console? It might be that you are loading your script before angular is loaded. Try to wrap your code in the function and place some breakpoints/debugs/console.log's to test at which point your code gets executed.

(function(){
  "use strict";

  angular.module('DesignPortal.layout', [])
      .controller('NgLayoutController', NgLayoutController);

  NgLayoutController.$inject = ['$scope'];

  function NgLayoutController($scope) {
      var loggedUserId = dpConfig.userInfo.id;
  }
})();

answered Apr 11, 2016 at 7:44

Miroslav Jonas

6,7172 gold badges30 silver badges42 bronze badges

1 Comment

Ashish Dwivedi Over a year ago

I've taken care of such things, and no there's no error in the console.

Karan Patel · Accepted Answer · 2016-04-11 07:26:19Z

0

Try this one. I have not tried my self but it should work.

<script type="text/javascript">
    angular.module('DesignPortal.layout', [])
        .controller('NgLayoutController',['$scope', function($scope) {
            function NgLayoutController() {
                var loggedUserId = dpConfig.userInfo.id;
            }
        }]);    
</script>

answered Apr 11, 2016 at 7:26

Karan Patel

2,3193 gold badges21 silver badges34 bronze badges

Collectives™ on Stack Overflow

Internal JS Angular Controller not getting called

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related