Javascript Search Function Error

Question

I am writing a search function within my Javascript code. However, it keeps on returning search function doesn't return correct contact information.

The goal of this search function is to return the contact information of the object , ie, firstName , lastName , number and address. If given an input Name , it matches one of the keys in the object I created, it should return the contact information and log it on the console.

var friends = {
    bill:{
        firstName : "Bill",
        lastName : "Gates",
        number : "(123) 456- 7890", 
        address : ['Microsoft', 20]
        },
    steve:{
        firstName : "Steve",
        lastName : "Jobs",
        number : "(123) 456- 7890",
        address : ['Apple', 30]
        }      
};
var friends1 = new Object();
var list =  function(friends1){
    for(var key in friends1){
        console.log(friends1[key].firstName.toLowerCase());   
    }  
};

var search = function(name){
 for(var key in friends1){
     if(friends1[key].firstName.toLowerCase() === name.toLowerCase()){
        console.log(friends1[key]);
        return friends1[key];
        }
 }   
};
list(friends1);
search("Steve");

Almost regardless what environment you're running your JavaScript in, there's a fully-featured debugger available that you can use to step through your code statement-by-statement, examine variables, etc. Using that is by far your best best for solving issues like this. In a browser, you'd access the "dev tools" (usually F12 and/or Ctrl+Shift+I or Cmd+Shift+I on a Mac). — T.J. Crowder
– T.J. Crowder, Commented May 15, 2016 at 11:09
Separately: Since list is irrelevant to the question, it would really be best not to include it in the question. — T.J. Crowder
– T.J. Crowder, Commented May 15, 2016 at 11:10

T.J. Crowder · Accepted Answer · 2020-06-24 08:41:21Z

2

In your search function, you loop through the keys in friends1. The friends1 that search closes over is the one from:

var friends1 = new Object();

...that you never add any properties to. So the loop won't do anything; there are no enumerable properties in the object you're querying.

Throughout search, you want friends, not friends1:

var friends = {
    bill:{
        firstName : "Bill",
        lastName : "Gates",
        number : "(123) 456- 7890", 
        address : ['Microsoft', 20]
        },
    steve:{
        firstName : "Steve",
        lastName : "Jobs",
        number : "(123) 456- 7890",
        address : ['Apple', 30]
        }      
};
var friends1 = new Object();

var search = function(name){
 for(var key in friends){
     if(friends[key].firstName.toLowerCase() === name.toLowerCase()){
        console.log(friends[key]);
        return friends[key];
     }
 }   
};
search("Steve");

edited Jun 24, 2020 at 8:41

answered May 15, 2016 at 11:08

T.J. Crowder

1.1m201 gold badges2k silver badges2k bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

T.J. Crowder Over a year ago

@ParagBhayani: Looking at it, I'd say it's because it doesn't solve the problem.

Parag Bhayani Over a year ago

for which case specifically?

T.J. Crowder Over a year ago

@ParagBhayani: Actually, it sort of does, but in a very strange way, and with comments descibing things incorrectly.

Collectives™ on Stack Overflow

Javascript Search Function Error

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related