String builder and String Concat

Question

I have a piece of code that look follows this pattern ,

 var stringBuilder =new StringBuilder( string.Concat(" string", _variable, 
"another string" , _variable2 ... );

according to some logic do

stringBuilder.Append(" Some more strings");

I don't like The mismatch of using StringBuilder and string.Concat and I want a more elegant way of doing

What I thought was using StringBuilder.Append like so ,

StringBuilder.Append("string");
StringBuilder.Append(_variable);
StringBuilder.Append("another string");

Is there a better way then this approach ?

StringBuilder.AppendFormat

001
– 001

2016-05-18 17:01:01 +00:00
Commented May 18, 2016 at 17:01 — 001
– 001, Commented May 18, 2016 at 17:01

Ivan Stoev · Accepted Answer · 2016-05-18 17:45:49Z

2

Actually the StringBuilder is AFAIK the first BCL class that supports fluent syntax, so you can simply chain multiple Append / AppendLine / AppendFormat calls:

var stringBuilder = new StringBuilder()
    .Append(" string").Append(_variable)
    .Append("another string").Append(_variable2)
    .Append(...);

answered May 18, 2016 at 17:45

Ivan Stoev

208k17 gold badges356 silver badges376 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Matt Rowland · Accepted Answer · 2016-05-18 16:56:27Z

0

In C# 6 you can use string interpolation:

var stringbuilder = new StringBuilder($"string{_variable}another string");

answered May 18, 2016 at 16:56

Matt Rowland

4,5954 gold badges28 silver badges36 bronze badges

3 Comments

Kenneth K. Over a year ago

Or in < C# 6 you can use string.Format.

Matt Rowland Over a year ago

@KennethK. yes but the question stated specifically about no liking the mismatch

Kenneth K. Over a year ago

Perhaps, but using string.Format at least cleans up the string literal to be one string rather than 3+ strings.

Ilya Chernomordik · Accepted Answer · 2016-05-18 17:00:21Z

0

StringBuilder is the proper way to do a lot of string concatenation. It is specifically made for that and is optimal from performance point of view, so if you want a lot of string operations, use it. Otherwise if it's one small operation you can follow Matt Rowland advise (if you have C# 6), though you won't need StringBuilder for that at all:

string result = $"string {_variable} another string"

If you don't have C# 6, you can do:

string result = string.Format("string {0} another string", _variable)

answered May 18, 2016 at 17:00

Ilya Chernomordik

30.9k31 gold badges148 silver badges245 bronze badges

Collectives™ on Stack Overflow

String builder and String Concat

3 Answers 3

Comments

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related