Rails: help refactoring controller

Question

I have a controller that I want to refactor. This controller basically renders a formatted XML document.

The controller does 4 main things.

It get records from a DB
It reads a static xml file from rails_root/config
It iterates through DB records and gsubs the XML doc using the DB data
It renders the XML document as :text

My question is:

Where is the correct place for 2/3 to happen within in the Rails framework? It seems to me that they shouldn't be in the controller.

I'm on Rails 2.3

Cheers

Platinum Azure · Accepted Answer · 2010-09-23 15:53:20Z

1

I don't know what best practice is, but in my case I'd do 1, 2, and 3 in one class method in the model. I'd create a model method that takes in the name of the base XML file.

So I'd do something like this... (CAVEAT: I'm not 100% sure about this being syntactically correct, I'm still kind of new to Rails)

# app/models/mymodel.rb
class MyModel < ActiveRecord::Base

  # ...

  def self.formatXml(xml_base)
    dataRecords = MyModel.find(:whatever) # step 1

    # open the XML and read it into a string, this is step 2
    # take the XML string, do the appropriate gsubs

    return my_xml_string;
  end
end

# app/controllers/mycontroller.rb
class MyController < ActionController::Base

  # ...

  def myAction
    formattedXml = MyModel.formatXml(whateverXmlFileName)

    render :text => formattedXml
  end
end

edited Sep 23, 2010 at 15:53

answered Sep 23, 2010 at 15:43

Platinum Azure

46.4k13 gold badges112 silver badges136 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Rails: help refactoring controller

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related