Append query string using htaccess URL rewrite not working

Question

I have this Apache Rewrite rules:

RewriteCond %{QUERY_STRING} !lang
RewriteCond %{HTTP_HOST} ^(jp|en|kr|cn)\.example\.com
RewriteRule ^(.*)$ http://%1.example.com/$1&lang=%1 [L, QSA]

RewriteCond %{HTTP_HOST} ^(jp|en|kr|cn)\.example\.com
RewriteRule ^(.*)$ http://%1.example.com/$1?lang=%1 [L, QSA]

What I expected is

http://en.example.com to http://en.example.com?lang=en
http://en.example.com/list.php to http://en.example.com/list.php?lang=en
http://en.example.com/product.php?id=1 to http://en.example.com/product.php?id=1&lang=en

(1) and (2) is fine, but what I got for (3) is

http://en.mobile-wifi_rental.local/product.php&lang=en?id=1.

Florian Lemaitre · Accepted Answer · 2016-06-21 15:28:57Z

1

You only need one rule for this, here it is:

RewriteEngine on
RewriteBase /

RewriteCond %{QUERY_STRING} !lang
RewriteCond %{HTTP_HOST} ^(jp|en|kr|cn)\.example\.com$
RewriteRule ^(.*)$ http://%1.example.com/$1?lang=%1 [L,QSA]

The problem with your first rule was the use of & instead of ? for the query string.

A generic version of it would be:

RewriteCond %{QUERY_STRING} !lang
RewriteCond %{HTTP_HOST} ^([a-z]{2})\.[^\.]+\.[^\.]+$
RewriteRule ^(.*)$ http://%{HTTP_HOST}/$1?lang=%1 [L,QSA]

edited Jun 21, 2016 at 15:28

answered Jun 21, 2016 at 15:21

Florian Lemaitre

5,7482 gold badges24 silver badges45 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Sithu Over a year ago

In my case, it doesn't need to be generic. I can use the exact country codes (jp|en|kr|cn) and domain (example.com).

Sithu Over a year ago

It tried your generic rule at htaccess.mwl.be. id=1 is not appended for http://en.example.com/product.php?id=1. The result is http://en.example.com/product.php?lang=en. What I want is like http://en.example.com/product.php?id=1&lang=en

Sithu Over a year ago

Yes, I only need one rule and it works on the real live server, the online tester htaccess.mwl.be is not just working as expected.

Florian Lemaitre Over a year ago

That's right I also tested it on the online tool that doesn't quite work as a real server.

Ivan Cachicatari · Accepted Answer · 2016-06-21 17:06:54Z

1

I changed your rules, %{QUERY_STRING} added manually:

RewriteCond %{QUERY_STRING} !lang
RewriteCond %{HTTP_HOST} ^(jp|en|kr|cn)\.example\.com
RewriteRule ^$ http://%1.example.com/?lang=%1   [L,QSA]

#Rule for empty query string
RewriteCond %{QUERY_STRING} ^$
RewriteCond %{HTTP_HOST} ^(jp|en|kr|cn)\.example\.com
RewriteRule ^(.*) http://%1.example.com/$1?lang=%1 [L]

RewriteCond %{QUERY_STRING} !lang
RewriteCond %{HTTP_HOST} ^(jp|en|kr|cn)\.example\.com
RewriteRule ^(.*) http://%1.example.com/$1?%{QUERY_STRING}&lang=%1 [L]

Tested with string: http://en.example.com/product.php?id=1 and the result is http://en.example.com/product.php?id=1&lang=en

edited Jun 21, 2016 at 17:06

answered Jun 21, 2016 at 15:40

Ivan Cachicatari

4,3143 gold badges24 silver badges41 bronze badges

7 Comments

Sithu Over a year ago

It almost works. I tried yours at htaccess.mwl.be for http://en.example.com/product.php. The output result is http://en.example.com/product.php?&lang=en with extra &

Ivan Cachicatari Over a year ago

Because it needs and extra rule to check if query_string is empty.

Ivan Cachicatari Over a year ago

@Sithu I added an extra rule to verify if query string is empty. Tested!

Sithu Over a year ago

Thanks, but then what is the difference between the first rule and the third rule?

Sithu Over a year ago

And without !lang it will cause redirect loop.

|

Collectives™ on Stack Overflow

Append query string using htaccess URL rewrite not working

2 Answers 2

4 Comments

7 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

7 Comments

Your Answer

Sign up or log in

Post as a guest

Related