C# WPF click event

Question

I wonder why click event does not show me the hp value of every loop. Its only shows me hp at the start and 0 at the end

private void button_Click(object sender, RoutedEventArgs e)
    {
        while (player.Hp > 0)
        {
            int vypocet = player.Damage(player2);
            player.Hp = vypocet;
            label.Content = vypocet;
        }
    }

This should be everything you need to know So as i said its only show me start hp and hp after whole fight and i dont know why its not show me other numbers if i am using while loop

Martin Zikmund · Accepted Answer · 2016-12-10 22:04:05Z

2

The reason is that the event handler runs on the UI thread. This means, the changed value can be reflected in the user interface only after the whole loop ends.

If you wanted to show the progress, you would have to run the computation on another thread and use the Dispatcher to notify the UI thread about the changes.

An alternative is to yield the UI thread regularly to give the UI a chance to update. This is however not very clean.

await Dispatcher.Yield(DispatcherPriority.ApplicationIdle);

answered Dec 10, 2016 at 22:04

Martin Zikmund

39.2k7 gold badges74 silver badges95 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Fabio · Accepted Answer · 2016-12-10 22:15:41Z

1

Because UI controls will be updated after button_Click method exits.

Try change method to asynchronous and use Task.Delay which will "release" UI thread for updating controls

private async void button_Click(object sender, RoutedEventArgs e)
{
    while (player.Hp > 0)
    {
        int vypocet = player.Damage(player2);
        player.Hp = vypocet;
        label.Content = vypocet;
        await Task.Delay(100);
    }
}

edited Dec 10, 2016 at 22:15

answered Dec 10, 2016 at 22:04

Fabio

32.5k4 gold badges35 silver badges77 bronze badges

1 Comment

Jakub Staněk Over a year ago

Wow thats really awesome. Thanks for it ! very useful for me

Collectives™ on Stack Overflow

C# WPF click event

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related