Inserting node in front of Linked List

Question

The below code is supposed to add a node at the front of a linked list and print the current elements. But running this code gives me run time error and the program terminates. When asking for how many numbers and i typed a number and then it shows "main.cpp has stopped working". What might be wrong ?

#include <iostream>
#include <stdio.h>
#include <stdlib.h>

struct Node
{

    int data;
    Node* next;
};
struct Node* head;
using namespace std;
void Insert(int x)
{
        Node* temp=new Node();
        temp->data=x;
        temp->next=head;
        head=temp;


}

void Print()
{
    Node* temp1=head;
    while(temp1!=NULL)
    {
        printf("%d\n",temp1->data);
        temp1=temp1->next;

    }
    printf("\n");
}

int main()
{
    head=NULL;
    printf("how many numbers?\n");
    int n,i,x;
    scanf("%d",n);
    for(i=0;i<n;i++)
    {
        printf("Enter the number: \n");
        scanf("%d",x);
        Insert(x);
        Print();
    }
    return 0;

}

Questions seeking debugging help (‘why isn't this code working?’) must include the desired behaviour, a specific problem or error and the shortest code necessary to reproduce it in the question itself. Questions without a clear problem statement are not useful to other readers. See: How to create a Minimal, Complete, and Verifiable example. — Biffen
– Biffen, Commented Jan 1, 2017 at 21:06
On a sidenote: You should learn to clean up - delete the memory you allocated when done. — Unimportant
– Unimportant, Commented Jan 1, 2017 at 21:11
This is not C++ - Use this to do the business. Also look into ifrsteam, — Ed Heal
– Ed Heal, Commented Jan 1, 2017 at 21:15

Jean-François Fabre · Accepted Answer · 2017-01-01 21:16:51Z

2

It's not even a linked list problem:

int n,i,x;
scanf("%d",n);

should be

int n,i,x;
scanf("%d",&n);

(there's another occurrence of that below)

because scanning integers need their address, as opposed to strings.

edited Jan 1, 2017 at 21:16

answered Jan 1, 2017 at 21:10

Jean-François Fabre♦

141k24 gold badges179 silver badges246 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Jean-François Fabre Over a year ago

BTW forget what I said about your linked list (now edited out), insertion looks okay. Trying to be a smartass needs more testing :)

Collectives™ on Stack Overflow

Inserting node in front of Linked List

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related