Delete row from database table with Laravel 5.2

Question

Recently I've started with Laravel 5.2 and I'm trying to make delete button which will delete row from database. Very basic and trivial but seems I can't make it.

I'm following documentation for delete: https://laravel.com/docs/5.2/queries#deletes

And I have made this. My route:

Route::post('flags/destroy/{delete}', 'FlagsController@destroy')->name('admin.flags.destroy');

Button in the view

{!! Html::linkRoute('admin.flags.destroy', 'Delete', $flag->report_id) !!}

and the controller

public function destroy(Request $request){

    $report = $request['report_id'];      

    Report::find($report);

    $report->delete();        
    $request->session()->flash('alert-success', ' Report is deleted successfully.');

    return redirect()->route('admin.flags');
}

I've tried solutions from other threads but I always got error:

MethodNotAllowedHttpException in compiled.php line 8936:

New error:

SQLSTATE[42S22]: Column not found: 1054 Unknown column 'reports.id' in 'where clause' (SQL: select * from `reports` where `reports`.`id` is null limit 1

Why is searching for id instead of report_id?

UPDATE:

button

{!! Html::linkRoute('admin.flags.destroy', 'Delete', $flag->report_id) !!}

Controller

public function destroy(Request $request){

    $report = $request['report_id'];      

    dd( $request->input('delete'));

    Report::where('report_id', $report)->first();

    $report->delete();        
    $request->session()->flash('alert-success', ' Report is deleted successfully.');

    return redirect()->route('admin.flags');
}

Route

Route::get('flags/destroy/{delete}', 'FlagsController@destroy')->name('admin.flags.destroy');

Update 2: This seems to work but is it secure enough? view:

 {!! Form::open(array('route' => array('admin.flags.destroy', $flag->report_id), 'method' => 'get')) !!}
        <button type="submit">Delete</button>
 {!! Form::close() !!}</td>

Controller

public function destroy($report_id){

  Report::destroy($report_id);
  //$request->session()->flash('alert-success', ' Report is deleted successfully.');

  return redirect()->route('admin.flags');
}

AddWeb Solution Pvt Ltd · Accepted Answer · 2017-01-18 11:49:36Z

5

I think your code need to update like:

public function destroy($delete){

   $report = $delete;      

   $rsltDelRec = Report::find($report);

   $rsltDelRec->delete();        
   $request->session()->flash('alert-success', ' Report is deleted successfully.');

   return redirect()->route('admin.flags');
}

Hope this work for you!

edited Jan 18, 2017 at 11:49

answered Jan 18, 2017 at 9:45

AddWeb Solution Pvt Ltd

21.8k5 gold badges30 silver badges61 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

VLS Over a year ago

Thanks for the answer. Got this Call to a member function delete() on string

VLS Over a year ago

dd($report); return "1" i.e. string

AddWeb Solution Pvt Ltd Over a year ago

@VLS Please check my answer. I made correction for it.

MevlütÖzdemir · Accepted Answer · 2017-01-18 18:07:49Z

2

Try this:

Controller:

  public function destroy(Report $report){

          $report->delete();

          return redirect()->route('admin.flags');

    }

answered Jan 18, 2017 at 18:07

MevlütÖzdemir

3,4981 gold badge27 silver badges33 bronze badges

Comments

Alexey Mezenin · Accepted Answer · 2017-01-18 09:17:19Z

1

You're creating get link but using post route. Change it to:

Route::get('flags/destroy/{delete}', 'FlagsController@destroy')->name('admin.flags.destroy');

answered Jan 18, 2017 at 9:17

Alexey Mezenin

164k27 gold badges309 silver badges287 bronze badges

3 Comments

Bugfixer Over a year ago

use reports_id not reports.id.check your query

VLS Over a year ago

I'm using it.. check the function and query in my question. It is requesting for report)id..

Bugfixer Over a year ago

check primary key in your model. it should be like protected $primaryKey = 'report_id'; // find() uses primary key // looks like you have $primaryKey = 'id'

Patryk Uszyński · Accepted Answer · 2017-01-18 09:29:38Z

1

MethodNotAllowedHttpException means that you are trying to access route with bad method. If you use Html::linkRoute then anchor is generated, but in your routes you have defined Route::post. You need to replace Route::post with Route::get. But if you want to make it safer you need to create simple form with delete button and CSRF token.

<form method="POST" action="{{ URL::route('admin.flags.destroy', {'delete' => $flag->report_id}) }}">
    {{ csrf_field() }}
    <!-- submit button -->
</form>

Why is searching for id instead of report_id?

You need to replace

Report::find($report);

with

$report = Report::where('report_id', $report)->first();

public function destroy(Request $request){

    $report = $request['report_id'];
    ....

You are trying here to access report_id in request, but in routes you named your parameter as delete

edited Jan 18, 2017 at 9:29

answered Jan 18, 2017 at 9:17

Patryk Uszyński

1,1211 gold badge13 silver badges23 bronze badges

14 Comments

VLS Over a year ago

Hm, now Call to a member function delete() on null this

Bugfixer Over a year ago

deleting a null value

Patryk Uszyński Over a year ago

change $request['report_id']; to $request['delete'];

VLS Over a year ago

Still same. @Bugfixer I know what is mean . just can't figure out why is null and how to fix

Patryk Uszyński Over a year ago

But someone who can send you mail, cant predict your token. They are unique and connected to your current session.

|

Collectives™ on Stack Overflow

Delete row from database table with Laravel 5.2

4 Answers 4

3 Comments

Comments

3 Comments

14 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

3 Comments

Comments

3 Comments

14 Comments

Your Answer

Sign up or log in

Post as a guest

Related