is there something wrong with this if statement i am trying to make a swing login system??? thanks :)
public void login()
{
String username = loginField.getText();
char[] password = loginPass.getPassword();
if (username.equals("test") && password.equals("test"))
{
System.out.println("logged in");
}
}
You might want
new String(password).equals("test")
instead. Comparing array to string makes little sense.
Yes. The part where you check the password is wrong. password is a char[]. So you have to change the way of checking it:
Way 1: Create a String of it
if (new String(password).equals("test"))
Way 2: Iterate over the array and check char by char:
public boolean checkPassword(char[] pass, String correctPass)
{
if (pass.length != correctPass.length()) return false;
for (int i = 0; i < pass.length; i++)
{
if (pass[i] != correctPass.charAt(i)) return false;
}
return true;
}
And in your if-statement
if (checkPassword(password, "test"))
Arrays.equals.password.equals("test")
will always return false, because test as String and password as char[] are different classes. They can never be equal.
But you can use the char[] representation of the String and check the arrays on equality via boolean java.utilArrays.equals(char[] a,char[] b):
java.util.Arrays.equals(password,"test".toCharArray())
In real life you may won't have password as String but already as char[].
Then of course you can directly use it in Arrays#equals.
Yes. 'password' is an array - doing an equals on it is a reference comparison. Convert it to a String and do equals on that.
EDIT: It looks like this is the "proper" way:
private static boolean isPasswordCorrect(char[] input) {
boolean isCorrect = true;
char[] correctPassword = { 'b', 'u', 'g', 'a', 'b', 'o', 'o' };
if (input.length != correctPassword.length) {
isCorrect = false;
} else {
isCorrect = Arrays.equals (input, correctPassword);
}
//Zero out the password.
Arrays.fill(correctPassword,'0');
return isCorrect;
}
From the java tutorials.
The char[] doesn't equals to a String. Try to create a String out of it:
new String(password).equals("test")
