Symfony API The controller must return a response

Question

I created a little crud system with a OneToMany relationship and want to create a little api as well.

I generated a new ApiBundle and added 1 controller for 1 of my entities that looks like this:

<?php

namespace ApiBundle\Controller;

use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use FOS\RestBundle\Controller\Annotations as Rest;
use FOS\RestBundle\Controller\FOSRestController;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use FOS\RestBundle\View\View;
use DataBundle\Entity\Job;

class JobController extends FOSRestController
{
    public function getAction()
    {
        $result = $this->getDoctrine()->getRepository('DataBundle:Job')->findAll();

        if ($result === null) {
            return new View("There are no jobs in the database", Response::HTTP_NOT_FOUND);
        }

        return $result;
    }

    public function idAction($id)
    {
        $result = $this->getDoctrine()->getRepository('DataBundle:Job')->find($id);

        if($result === null) {
            return new View("Job not found", Response::HTTP_NOT_FOUND);
        }

        return $result;
    }

}

But when I make a call to /api/jobs i get the following error:

Uncaught PHP Exception LogicException: "The controller must return a response (Array(0 => Object(DataBundle\Entity\Job), 1 => Object(DataBundle\Entity\Job)) given)."

Anyone has any idea what I am doing wrong here?

Any help is appreciated!

Many thanks in advance :)

symfony.com/doc/current/controller.html

Max P.
– Max P.

2017-02-26 16:23:31 +00:00
Commented Feb 26, 2017 at 16:23 — Max P.
– Max P., Commented Feb 26, 2017 at 16:23

iulyanp · Accepted Answer · 2017-02-26 18:26:14Z

8

The error is telling you to return a response. Something like this:

return new Response(
        'There are no jobs in the database', 
         Response::HTTP_OK
    );

or if you want a json response you can do something like this

return new JsonResponse(
         [
             'message' => 'There are no jobs in the database', 
         ]
         Response::HTTP_OK
    );

answered Feb 26, 2017 at 18:26

iulyanp

913 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Alexandr Podgorbunschih · Accepted Answer · 2017-02-27 10:02:28Z

0

Controller must return an Response object, you are returning the $result.

answered Feb 27, 2017 at 10:02

Alexandr Podgorbunschih

495 bronze badges

Comments

Alvin Bunk · Accepted Answer · 2017-02-26 17:39:22Z

-1

Can you try this:

$view = $this->view($result, Response::HTTP_OK);
return $view;

Let us know if that works.

answered Feb 26, 2017 at 17:39

Alvin Bunk

7,8123 gold badges31 silver badges48 bronze badges

Collectives™ on Stack Overflow

Symfony API The controller must return a response

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related