php inline if statement not working

Question

I am not sure what I am doing wrong, but the inline if statement always returns true, even if it is not supposed to.

I have the following statement

<?php echo ($total == 'Scratched' || ($total > 0 && $total < 65)) ? 'ffefef' : 'f7f7f7'; ?>

Just above this statement, I echo $total and that echoes out 0

At the top of the page I define <?php $total = 0; ?>, so $total is defined as an integer.

The above if statement only returns false if $total > 64 but not when total is 0

Thanks in advance

@MarkBaker, but there is no nested ternaries in the question — Alex Blex
– Alex Blex, Commented Mar 2, 2017 at 9:27
Possible duplicate of How do the PHP equality (== double equals) and identity (=== triple equals) comparison operators differ? — TZHX
– TZHX, Commented Mar 2, 2017 at 9:44

smarber · Accepted Answer · 2017-03-02 09:29:23Z

6

It's because 0 == 'Scratched'

 // Strict comparison fixes it
 echo ($total === 'Scratched' || ($total > 0 && $total < 65)) ? 'ffefef' : 'f7f7f7';

answered Mar 2, 2017 at 9:29

smarber

5,1447 gold badges41 silver badges86 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Hossam · Accepted Answer · 2017-03-02 09:28:50Z

3

This is working

<?php 
$total = 0;
echo ($total === 'Scratched' || ($total > 0 && $total < 65)) ? 'ffefef' : 'f7f7f7';
?>

answered Mar 2, 2017 at 9:28

Hossam

1,1469 silver badges19 bronze badges

Comments

Reyan Tropia · Accepted Answer · 2017-03-02 09:32:25Z

3

Base on your given situation. If I understand it quite well. Your state wont accept it as false if its 0.

The above code should work. But try explicitly adding the not equal zero:

echo ($total === 'Scratched' || ($total > 0 && $total < 65 && $total != 0)) ? 'ffefef' : 'f7f7f7';

Also added === to make sure the first statement of type string.

answered Mar 2, 2017 at 9:32

Reyan Tropia

1401 silver badge10 bronze badges

Comments

Rafiqul Islam · Accepted Answer · 2017-03-02 09:39:33Z

1

Use === to compare $total === 'Scratched' and that will fixed

 <?php echo ($total === 'Scratched' || ($total > 0 && $total < 65)) ? 'ffefef' : 'f7f7f7'; ?>

answered Mar 2, 2017 at 9:39

Rafiqul Islam

1,6561 gold badge14 silver badges25 bronze badges

Comments

Community · Accepted Answer · 2017-05-23 11:46:43Z

0

You can try strict comparison:

<?php echo ($total === 'Scratched' || ($total > 0 && $total < 65)) ? 'ffefef' : 'f7f7f7'; ?>

Because of comparing a numeric variable over a string, the string is evaluated in a numeric context and represents 0.

You can take a look at the folowing post: Comparing String to Integer gives strange results

edited May 23, 2017 at 11:46

CommunityBot

11 silver badge

answered Mar 2, 2017 at 9:47

Alexis Markopoulos

291 silver badge7 bronze badges

Collectives™ on Stack Overflow

php inline if statement not working

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related