Django rest framework: 'create( )' NotImplementedError when making Http POST request

Question

When making a post request in Django I get the error that 'create()' has not been implemented when I did indeed implement it in my serializer file

from rest_framework import serializers
from people.models import People

class PeopleSerializer(serializers.Serializer):
    pk = serializers.IntegerField(read_only=True)
    name = serializers.CharField(max_length=200)
    favoriteCity = serializers.CharField(max_length=200)

    def create(self, validated_data):
        return People.objects.create(**validated_data)

    def update(self, instance, validated_data):
        instance.name = validated_data.get('name', instance.name)
        instance.favoriteCity = validated_data.get(
                                'favoriteCity',instance.favoriteCity)
        instance.save()
        return instance()

Clearly the create method has been implemented and I don't understand why i'm getting a NotImplementedError

Something is probably missing in your view. Are you using viewsets ? generic views? — pchiquet
– pchiquet, Commented Mar 20, 2017 at 22:40

dushyant7917 · Accepted Answer · 2017-07-11 06:34:14Z

49

In your serializer class inherit from ModelSerializer instead of Serializer class since the later doesn't call create() method implicitly.

class PeopleSerializer(serializers.ModelSerializer):

The above change would do your job!

answered Jul 11, 2017 at 6:34

dushyant7917

6548 silver badges9 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Vivesh Kumar · Accepted Answer · 2022-08-23 14:35:27Z

4

Please check your indentation, that 'create' function should be inside that Serializer class, as below example.

class StudentSerializer(serializers.Serializer):
    name = serializers.CharField(max_length=111)
    roll = serializers.IntegerField()
    city = serializers.CharField(max_length=722)

    def create(self,validated_data):
        return Student.objects.create(**validated_data)

answered Aug 23, 2022 at 14:35

Vivesh Kumar

393 bronze badges

Comments

Hardik Asnani · Accepted Answer · 2019-07-06 11:59:06Z

-1

Check if the keys inside data exactly match model attributes when you try to create an object of a particular model using the model serializer

answered Jul 6, 2019 at 11:59

Hardik Asnani

12 bronze badges

Comments

Manzar Abbas · Accepted Answer · 2022-06-13 21:25:20Z

-1

Please check your indentation, that 'create' function should be within that Serializer class Hopefully it will work.

answered Jun 13, 2022 at 21:25

Manzar Abbas

7

1 Comment

Manzar Abbas Over a year ago

from rest_framework import serializers from .models import Student class StudentSerializer(serializers.Serializer): name=serializers.CharField(max_length=555) age=serializers.CharField(max_length=555) city=serializers.CharField(max_length=555) def create(self,validated_data): return Student.objects.create(**validated_data)

Manzar Abbas · Accepted Answer · 2022-06-13 21:29:44Z

-1

from rest_framework import serializers from .models import Student

class StudentSerializer(serializers.Serializer): name=serializers.CharField(max_length=555) def create(self,validated_data): return Student.objects.create(**validated_data)enter image description here

answered Jun 13, 2022 at 21:29

Manzar Abbas

7

Collectives™ on Stack Overflow

Django rest framework: 'create( )' NotImplementedError when making Http POST request

5 Answers 5

Comments

Comments

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related